-
Notifications
You must be signed in to change notification settings - Fork 4
Add default claims policies for id_token #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added default claims policies for id_token in values.yaml. Signed-off-by: Asitha de Silva <[email protected]>
WalkthroughAdds a default Authelia OIDC claims policy mapping four ID token claims and references that policy from the lfx OIDC client in the Helm values file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds default claims policies for OpenID Connect (OIDC) id_tokens in the Authelia configuration. The changes configure which user claims will be included in id_tokens by default and apply this policy to the Heimdall client.
- Added a default claims policy specifying standard OIDC claims (email, email_verified, name, preferred_username) to be included in id_tokens
- Applied the default claims policy to the Heimdall client
- Added a new scope
update:current_user_metadatato the Heimdall client's allowed scopes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
charts/lfx-platform/values.yaml
Outdated
| - profile | ||
| - offline_access | ||
| - access:api | ||
| - update:current_user_metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense to me. access:api matches the audience defined on the next line (lfx-api). However update:current_user_metadata is for the management API, which we don't even have defined in Authelia. I assume we would just skip making those API calls or getting the tokens locally. However, in the event that we add another API/audience in dev, like a mock Auth0 API, then we could add this (in other words, I'd be expecting to see audience getting updated, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added by accident.
emsearcy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding claims_policy to make these claims be in the ID token, instead of only in userinfo, looks good, but adding Management API scopes doesn't make sense to me.
Removed 'update:current_user_metadata' from the scopes list. Signed-off-by: Asitha de Silva <[email protected]>
Added default claims policies for id_token in values.yaml.