-
Notifications
You must be signed in to change notification settings - Fork 4
[LFXV2-618] add lfx-v2-mailing-list-service to platform chart #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Prabodh Chaudhari <[email protected]>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughBumps lfx-platform chart version to 0.3.4 and adds a new Helm dependency entry for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds the new lfx-v2-mailing-list-service to the LFX Platform Helm chart by declaring it as a dependency and supplying default values, along with a version bump of the parent chart.
- Added new Helm dependency entry for lfx-v2-mailing-list-service
- Introduced default values (currently enabled) for the new service
- Bumped chart version from 0.3.2 to 0.3.3
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/lfx-platform/Chart.yaml | Added dependency block for mailing list service and bumped chart version |
| charts/lfx-platform/values.yaml | Added default values (including enabled flag) for mailing list service |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Prabodh Chaudhari <[email protected]>
Signed-off-by: Prabodh Chaudhari <[email protected]>
Signed-off-by: Prabodh Chaudhari <[email protected]>
Issue - https://linuxfoundation.atlassian.net/browse/LFXV2-618
This pull request updates the Helm chart for the LFX Platform to add support for the new mailing list service. The main changes include bumping the chart version, adding the mailing list service as a dependency, and providing default configuration values for it.
Helm chart version update:
Chart.yamlfrom0.3.2to0.3.3to reflect the new changes.Dependency management:
lfx-v2-mailing-list-serviceas a new dependency inChart.yaml, including its repository, version constraint, and enablement condition.Default configuration:
lfx-v2-mailing-list-serviceinvalues.yaml, enabling the service and setting its domain.