Skip to content

Commit a725846

Browse files
committed
fix: remove redundant kernel version check in plymouth theme setup
The change removes an unnecessary kernel version check when setting the Plymouth theme. The check was redundant because the subsequent update- initramfs command already handles all kernel versions with the "-k all" parameter. This simplifies the code and removes an unnecessary system call. Influence: 1. Verify Plymouth theme changes still work correctly 2. Check that initramfs updates properly for all kernel versions 3. Test system boot process with different themes fix: 移除Plymouth主题设置中多余的内核版本检查 该变更移除了设置Plymouth主题时不必要的内核版本检查。由于后续的update- initramfs命令已经通过"-k all"参数处理所有内核版本,这个检查是多余的。这 简化了代码并移除了不必要的系统调用。 Influence: 1. 验证Plymouth主题更改仍能正常工作 2. 检查initramfs是否能为所有内核版本正确更新 3. 使用不同主题测试系统启动过程
1 parent 05586ca commit a725846

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

bin/dde-system-daemon/plymouth.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,6 @@ func (d *Daemon) setPlymouthTheme(themeName string) error {
167167
return fmt.Errorf("failed to set plymouth theme: %s, err: %v", string(out), err)
168168
}
169169

170-
kernel, err := exec.Command("uname", "-r").CombinedOutput()
171-
if err != nil {
172-
return fmt.Errorf("failed to get kernel, err: %v", err)
173-
}
174170
out, err = exec.Command("update-initramfs", "-u", "-k", "all").CombinedOutput()
175171
if err != nil {
176172
return fmt.Errorf("failed to update initramfs: %s, err: %v", string(out), err)

debian/changelog

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
dde-daemon (6.1.47) unstable; urgency=medium
2+
3+
* fix: remove redundant kernel version check in plymouth theme setup
4+
5+
-- lvpeilong <[email protected]> Fri, 01 Aug 2025 10:00:00 +0800
6+
17
dde-daemon (6.1.46) unstable; urgency=medium
28

39
* fix: update initramfs for all kernels instead of current

0 commit comments

Comments
 (0)