Skip to content

Commit

Permalink
Add utime07 test
Browse files Browse the repository at this point in the history
This test has been extracted from symlink01 test and it verifies that
utime() is working correctly on symlink() generated files.

Link: https://lore.kernel.org/ltp/[email protected]/
Reviewed-by: Avinesh Kumar <[email protected]>
Reviewed-by: Petr Vorel <[email protected]>
Signed-off-by: Andrea Cervesato <[email protected]>
[ pvorel: extend doc ]
Signed-off-by: Petr Vorel <[email protected]>
  • Loading branch information
acerv authored and pevik committed May 7, 2024
1 parent b8a5974 commit 5cfb7f5
Show file tree
Hide file tree
Showing 4 changed files with 102 additions and 2 deletions.
2 changes: 1 addition & 1 deletion runtest/smoketest
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ wait02 wait02
write01 write01
symlink01 symlink01
stat04 symlink01 -T stat04
utime01A symlink01 -T utime01
utime07 utime07
rename01A symlink01 -T rename01
splice02 splice02 -s 20
df01_sh df01.sh
Expand Down
2 changes: 1 addition & 1 deletion runtest/syscalls
Original file line number Diff line number Diff line change
Expand Up @@ -1677,12 +1677,12 @@ ustat01 ustat01
ustat02 ustat02

utime01 utime01
utime01A symlink01 -T utime01
utime02 utime02
utime03 utime03
utime04 utime04
utime05 utime05
utime06 utime06
utime07 utime07

utimes01 utimes01

Expand Down
1 change: 1 addition & 0 deletions testcases/kernel/syscalls/utime/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
/utime04
/utime05
/utime06
/utime07
99 changes: 99 additions & 0 deletions testcases/kernel/syscalls/utime/utime07.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
* Authors: David Fenner, Jon Hendrickson
* Copyright (C) 2024 Andrea Cervesato <[email protected]>
*/

/*\
* [Description]
*
* This test verifies that utime() is working correctly on symlink()
* generated files.
*
* Also verify if utime() fails:
*
* - ENOENT when symlink points to nowhere
* - ELOOP when symlink is looping
*/

#include <utime.h>
#include "tst_test.h"

#define TIME_DIFF 100

static void create_symlink(const char *path, const char *symname)
{
struct stat asymlink;

SAFE_SYMLINK(path, symname);
SAFE_LSTAT(symname, &asymlink);

if ((asymlink.st_mode & S_IFMT) != S_IFLNK) {
tst_brk(TBROK, "symlink generated a non-symbolic link %s to %s",
symname, path);
}
}

static void test_utime(void)
{
char *symname = "my_symlink0";
struct stat oldsym_stat;
struct stat newsym_stat;

tst_res(TINFO, "Test if utime() changes access time");

create_symlink(tst_get_tmpdir(), symname);
SAFE_STAT(symname, &oldsym_stat);

struct utimbuf utimes = {
.actime = oldsym_stat.st_atime + TIME_DIFF,
.modtime = oldsym_stat.st_mtime + TIME_DIFF
};

TST_EXP_PASS(utime(symname, &utimes));
SAFE_STAT(symname, &newsym_stat);

TST_EXP_EQ_LI(newsym_stat.st_atime - oldsym_stat.st_atime, TIME_DIFF);
TST_EXP_EQ_LI(newsym_stat.st_mtime - oldsym_stat.st_mtime, TIME_DIFF);

SAFE_UNLINK(symname);
}

static void test_utime_no_path(void)
{
char *symname = "my_symlink1";
struct utimbuf utimes;

tst_res(TINFO, "Test if utime() raises ENOENT when symlink points to nowhere");

create_symlink("bc+eFhi!k", symname);
TST_EXP_FAIL(utime(symname, &utimes), ENOENT);

SAFE_UNLINK(symname);
}

static void test_utime_loop(void)
{
char *symname = "my_symlink2";
struct utimbuf utimes;

tst_res(TINFO, "Test if utime() raises ELOOP when symlink is looping");

create_symlink(symname, symname);
TST_EXP_FAIL(utime(symname, &utimes), ELOOP);

SAFE_UNLINK(symname);
}

static void run(void)
{
test_utime();
test_utime_no_path();
test_utime_loop();
}

static struct tst_test test = {
.test_all = run,
.needs_tmpdir = 1,
};

0 comments on commit 5cfb7f5

Please sign in to comment.