Fix NodeBalancerVPCConfig struct and address copilot suggestions

Author: dawiddzhafarov

linode_api4/objects/nodebalancer.py

@@ -243,11 +243,11 @@ class NodeBalancerVPCConfig(DerivedBase):
     properties = {
         "id": Property(identifier=True),
         "nodebalancer_id": Property(identifier=True),
-        "ipv4_range": Property(mutable=True),
-        "ipv4_range_auto_assign": Property(mutable=True),
-        "subnet_id": Property(mutable=True),
-        "vpc_id": Property(mutable=True),
-        "purpose": Property(mutable=True),
+        "ipv4_range": Property(),
+        "ipv6_range": Property(),
+        "subnet_id": Property(),
+        "vpc_id": Property(),
+        "purpose": Property(),
     }
 
 
@@ -413,7 +413,10 @@ def vpc(self, id):
         :rtype: NodeBalancerVPCConfig
         """
         result = self._client.get(
-            "{}/vpcs/{}".format(NodeBalancer.api_endpoint, id), model=self
+            "{}/vpcs/{}".format(
+                NodeBalancer.api_endpoint, parse.quote(str(id))
+            ),
+            model=self,
         )
 
         return NodeBalancerVPCConfig(

test/fixtures/nodebalancers_12345_backend__vpcs.json

@@ -6,7 +6,7 @@
             "subnet_id": 6666,
             "vpc_id": 222,
             "ipv4_range": "10.200.1.0/24",
-            "ipv4_range_auto_assign": false,
+            "ipv6_range": "2001:db8:2::/64",
             "purpose": "backend"
         }
     ],

test/fixtures/nodebalancers_12345_frontend__vpcs.json

@@ -6,7 +6,7 @@
             "subnet_id": 5555,
             "vpc_id": 111,
             "ipv4_range": "10.100.5.0/24",
-            "ipv4_range_auto_assign": false,
+            "ipv6_range": "2001:db8::/64",
             "purpose": "frontend"
         }
     ],

test/fixtures/nodebalancers_12345_vpcs.json

@@ -6,7 +6,7 @@
             "subnet_id": 5555,
             "vpc_id": 111,
             "ipv4_range": "10.100.5.0/24",
-            "ipv4_range_auto_assign": false,
+            "ipv6_range": "2001:db8::/64",
             "purpose": "frontend"
         },
         {
@@ -15,7 +15,7 @@
             "subnet_id": 5556,
             "vpc_id": 112,
             "ipv4_range": "10.100.6.0/24",
-            "ipv4_range_auto_assign": false,
+            "ipv6_range": "2001:db8:1::/64",
             "purpose": "backend"
         }
     ],

test/fixtures/nodebalancers_12345_vpcs_99.json

@@ -4,6 +4,6 @@
     "subnet_id": 5555,
     "vpc_id": 111,
     "ipv4_range": "10.100.5.0/24",
-    "ipv4_range_auto_assign": false,
+    "ipv6_range": "2001:db8::/64",
     "purpose": "frontend"
 }

test/unit/objects/nodebalancers_test.py

@@ -317,13 +317,15 @@ def test_vpcs(self):
             self.assertEqual(result[0].subnet_id, 5555)
             self.assertEqual(result[0].vpc_id, 111)
             self.assertEqual(result[0].ipv4_range, "10.100.5.0/24")
+            self.assertEqual(result[0].ipv6_range, "2001:db8::/64")
             self.assertEqual(result[0].purpose, "frontend")
 
             self.assertIsInstance(result[1], NodeBalancerVPCConfig)
             self.assertEqual(result[1].id, 100)
             self.assertEqual(result[1].subnet_id, 5556)
             self.assertEqual(result[1].vpc_id, 112)
             self.assertEqual(result[1].ipv4_range, "10.100.6.0/24")
+            self.assertEqual(result[1].ipv6_range, "2001:db8:1::/64")
             self.assertEqual(result[1].purpose, "backend")
 
     def test_vpc(self):
@@ -341,6 +343,7 @@ def test_vpc(self):
             self.assertEqual(result.subnet_id, 5555)
             self.assertEqual(result.vpc_id, 111)
             self.assertEqual(result.ipv4_range, "10.100.5.0/24")
+            self.assertEqual(result.ipv6_range, "2001:db8::/64")
             self.assertEqual(result.purpose, "frontend")
 
     def test_backend_vpcs(self):
@@ -359,6 +362,7 @@ def test_backend_vpcs(self):
             self.assertEqual(result[0].subnet_id, 6666)
             self.assertEqual(result[0].vpc_id, 222)
             self.assertEqual(result[0].ipv4_range, "10.200.1.0/24")
+            self.assertEqual(result[0].ipv6_range, "2001:db8:2::/64")
             self.assertEqual(result[0].purpose, "backend")
 
     def test_frontend_vpcs(self):
@@ -377,4 +381,5 @@ def test_frontend_vpcs(self):
             self.assertEqual(result[0].subnet_id, 5555)
             self.assertEqual(result[0].vpc_id, 111)
             self.assertEqual(result[0].ipv4_range, "10.100.5.0/24")
+            self.assertEqual(result[0].ipv6_range, "2001:db8::/64")
             self.assertEqual(result[0].purpose, "frontend")