Refactor Web Part 2

Author: linkdotnet

src/Directory.Build.props

@@ -13,6 +13,7 @@
         <AnalysisLevel>latest</AnalysisLevel>
         <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 			  <NuGetAuditLevel>critical</NuGetAuditLevel>
+			  <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <PropertyGroup Condition="'$(Configuration)' == 'Release'">

src/LinkDotNet.Blog.Domain/Entity.cs

@@ -2,5 +2,5 @@
 
 public abstract class Entity
 {
-    public string Id { get; set; } = string.Empty;
+    public string Id { get; set; } = default!;
 }

src/LinkDotNet.Blog.Infrastructure/Persistence/CachedRepository.cs

@@ -22,7 +22,7 @@ public CachedRepository(IRepository<T> repository, IMemoryCache memoryCache)
 
     public ValueTask<HealthCheckResult> PerformHealthCheckAsync() => repository.PerformHealthCheckAsync();
 
-    public async ValueTask<T> GetByIdAsync(string id) =>
+    public async ValueTask<T?> GetByIdAsync(string id) =>
         (await memoryCache.GetOrCreateAsync(id, async entry =>
         {
             entry.SlidingExpiration = TimeSpan.FromDays(7);

src/LinkDotNet.Blog.Infrastructure/Persistence/IRepository.cs

@@ -12,7 +12,7 @@ public interface IRepository<TEntity>
 {
     ValueTask<HealthCheckResult> PerformHealthCheckAsync();
 
-    ValueTask<TEntity> GetByIdAsync(string id);
+    ValueTask<TEntity?> GetByIdAsync(string id);
 
     ValueTask<IPagedList<TEntity>> GetAllAsync(
         Expression<Func<TEntity, bool>>? filter = null,

src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/Repository.cs

@@ -15,10 +15,10 @@ public sealed class Repository<TEntity> : IRepository<TEntity>
 
     public ValueTask<HealthCheckResult> PerformHealthCheckAsync() => ValueTask.FromResult(HealthCheckResult.Healthy());
 
-    public ValueTask<TEntity> GetByIdAsync(string id)
+    public ValueTask<TEntity?> GetByIdAsync(string id)
     {
-        var entity = entities.First(b => b.Id == id);
-        return new ValueTask<TEntity>(entity);
+        var entity = entities.Find(b => b.Id == id);
+        return new ValueTask<TEntity?>(entity);
     }
 
     public ValueTask<IPagedList<TEntity>> GetAllAsync(Expression<Func<TEntity, bool>>? filter = null,

src/LinkDotNet.Blog.Infrastructure/Persistence/MongoDB/Repository.cs

@@ -36,7 +36,7 @@ public async ValueTask<HealthCheckResult> PerformHealthCheckAsync()
         }
     }
 
-    public async ValueTask<TEntity> GetByIdAsync(string id)
+    public async ValueTask<TEntity?> GetByIdAsync(string id)
     {
         var filter = Builders<TEntity>.Filter.Eq(e => e.Id, id);
         var result = await Collection.FindAsync(filter);

src/LinkDotNet.Blog.Infrastructure/Persistence/RavenDb/Repository.cs

@@ -33,7 +33,7 @@ public async ValueTask<HealthCheckResult> PerformHealthCheckAsync()
         }
     }
 
-    public async ValueTask<TEntity> GetByIdAsync(string id)
+    public async ValueTask<TEntity?> GetByIdAsync(string id)
     {
         using var session = documentStore.OpenAsyncSession();
         return await session.LoadAsync<TEntity>(id);

src/LinkDotNet.Blog.Infrastructure/Persistence/Sql/Repository.cs

@@ -36,10 +36,10 @@ public async ValueTask<HealthCheckResult> PerformHealthCheckAsync()
         }
     }
 
-    public async ValueTask<TEntity> GetByIdAsync(string id)
+    public async ValueTask<TEntity?> GetByIdAsync(string id)
     {
         var blogDbContext = await dbContextFactory.CreateDbContextAsync();
-        return await blogDbContext.Set<TEntity>().FirstAsync(b => b.Id == id);
+        return await blogDbContext.Set<TEntity>().FirstOrDefaultAsync(b => b.Id == id);
     }
 
     public ValueTask<IPagedList<TEntity>> GetAllAsync(Expression<Func<TEntity, bool>>? filter = null,

src/LinkDotNet.Blog.Web/Features/Archive/ArchivePage.razor

@@ -44,7 +44,7 @@
 </div>
 
 @code {
-	private IReadOnlyCollection<IGrouping<int, BlogPostPerYear>> blogPostsPerYear = [];
+	private IReadOnlyCollection<IGrouping<int, BlogPostPerYear>>? blogPostsPerYear;
 	private int blogPostCount;
 
 	protected override async Task OnInitializedAsync()

src/LinkDotNet.Blog.Web/Features/ShowBlogPost/ShowBlogPostPage.razor

@@ -123,7 +123,8 @@ else if (BlogPost is not null)
 
     private async Task UpdateLikes(bool hasLiked)
     {
-        BlogPost = await BlogPostRepository.GetByIdAsync(BlogPostId);
+        BlogPost = await BlogPostRepository.GetByIdAsync(BlogPostId)
+                   ?? throw new InvalidOperationException("Blog post not found");
         BlogPost.Likes = hasLiked ? BlogPost.Likes + 1 : BlogPost.Likes - 1;
         await BlogPostRepository.StoreAsync(BlogPost);
     }