diff --git a/.editorconfig b/.editorconfig index 91034b63..14f62484 100644 --- a/.editorconfig +++ b/.editorconfig @@ -397,20 +397,6 @@ dotnet_naming_rule.parameters_rule.severity = warning # Code Analyzers Rules ########################################## -# AsyncFixer -# http://www.asyncfixer.com - - -# Meziantou -# https://www.meziantou.net/enforcing-asynchronous-code-good-practices-using-a-roslyn-analyzer.htm -dotnet_diagnostic.MA0003.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0003.md -dotnet_diagnostic.MA0004.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0004.md -dotnet_diagnostic.MA0016.severity = error # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0016.md -dotnet_diagnostic.MA0025.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0025.md -dotnet_diagnostic.MA0026.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0026.md -dotnet_diagnostic.MA0028.severity = none # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/Meziantou/MA0028.md - - # Microsoft - Code Analysis # https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ dotnet_diagnostic.CA1707.severity = error # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/MicrosoftCodeAnalysis/CA1707.md @@ -419,7 +405,9 @@ dotnet_diagnostic.CA2007.severity = none # https://github.com/atc-net # SonarAnalyzer.CSharp # https://rules.sonarsource.com/csharp -dotnet_diagnostic.S1135.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/SonarAnalyzerCSharp/S1135.md +dotnet_diagnostic.S1118.severity = none # Add a 'protected' constructor or the 'static' keyword to the class declaration. +dotnet_diagnostic.S1135.severity = suggestion # https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/SonarAnalyzerCSharp/S1135.md +dotnet_diagnostic.S3875.severity = none # Remove this overload of 'operator =='. ########################################## # Custom - Code Analyzers Rules @@ -500,3 +488,4 @@ dotnet_diagnostic.S125.severity = none # S125: Sections of code should not be co dotnet_diagnostic.S3459.severity = none # S3459: Unassigned members should be removed dotnet_diagnostic.S3871.severity = none # S3871: Exception types should be "public" dotnet_diagnostic.S1186.severity = none # S1186: Methods should not be empty +dotnet_diagnostic.S6608.severity = none # S6608: Indexing at Count-1 should be used instead of "Enumerable" extension method "Last" \ No newline at end of file diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 21abadba..1b4eaa86 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -5,19 +5,8 @@ all runtime; build; native; contentfiles; analyzers; buildtransitive - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - - - - - $(MSBuildThisFileDirectory)\..\stylecop.analyzers.ruleset - - AllEnabledByDefault true diff --git a/stylecop.analyzers.ruleset b/stylecop.analyzers.ruleset deleted file mode 100644 index ba8d1e47..00000000 --- a/stylecop.analyzers.ruleset +++ /dev/null @@ -1,475 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/stylecop.json b/stylecop.json deleted file mode 100644 index 78b338a8..00000000 --- a/stylecop.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json", - "settings": { - "documentationRules": { - "companyName": "Tunnel Vision Laboratories, LLC", - "copyrightText": "Copyright (c) {companyName}. All Rights Reserved.\r\nLicensed under the MIT License. See LICENSE in the project root for license information.", - "xmlHeader": false, - "fileNamingConvention": "metadata" - }, - "namingRules": { - "tupleElementNameCasing": "camelCase" - }, - "orderingRules": { - "usingDirectivesPlacement": "outsideNamespace" - }, - "indentation": { - "indentationSize": 4, - "tabSize": 4, - "useTabs": false - } - } -} \ No newline at end of file diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 19fa603d..910bef52 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -22,11 +22,7 @@ - - all - runtime; build; native; contentfiles; analyzers; buildtransitive - - + all runtime; build; native; contentfiles; analyzers; buildtransitive @@ -40,13 +36,6 @@ - - - - - $(MSBuildThisFileDirectory)\..\stylecop.analyzers.ruleset - - 5 true diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/RavenDb/BlogPostRepositoryTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/RavenDb/BlogPostRepositoryTests.cs index ee3322d6..26584248 100644 --- a/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/RavenDb/BlogPostRepositoryTests.cs +++ b/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/RavenDb/BlogPostRepositoryTests.cs @@ -58,7 +58,7 @@ public async Task ShouldFilterAndOrder() false); var retrievedPosts = blogPosts.ToList(); - retrievedPosts.Any(b => b.Id == filteredOutPost.Id).Should().BeFalse(); + retrievedPosts.Exists(b => b.Id == filteredOutPost.Id).Should().BeFalse(); retrievedPosts[0].Id.Should().Be(olderPost.Id); retrievedPosts[1].Id.Should().Be(newerPost.Id); } diff --git a/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs index c76ee073..60a35ad3 100644 --- a/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs +++ b/tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs @@ -101,7 +101,7 @@ public async Task ShouldFilterAndOrder() false); var retrievedPosts = blogPosts.ToList(); - retrievedPosts.Any(b => b.Id == filteredOutPost.Id).Should().BeFalse(); + retrievedPosts.Exists(b => b.Id == filteredOutPost.Id).Should().BeFalse(); retrievedPosts[0].Id.Should().Be(olderPost.Id); retrievedPosts[1].Id.Should().Be(newerPost.Id); } diff --git a/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs b/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs index 033f76fd..f14557a4 100644 --- a/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs +++ b/tests/LinkDotNet.Blog.IntegrationTests/SmokeTests.cs @@ -56,7 +56,7 @@ public async Task ShouldAllowDotsForFreeTextSearch() { var client = factory.CreateClient(); - var result = await client.GetAsync("/searchByTag/.NET5"); + var result = await client.GetAsync("/search/.NET5"); result.IsSuccessStatusCode.Should().BeTrue(); } diff --git a/tests/LinkDotNet.Blog.UnitTests/Infrastructure/Persistence/InMemory/BlogPostRepositoryTests.cs b/tests/LinkDotNet.Blog.UnitTests/Infrastructure/Persistence/InMemory/BlogPostRepositoryTests.cs index 5a0176f3..8ec7c869 100644 --- a/tests/LinkDotNet.Blog.UnitTests/Infrastructure/Persistence/InMemory/BlogPostRepositoryTests.cs +++ b/tests/LinkDotNet.Blog.UnitTests/Infrastructure/Persistence/InMemory/BlogPostRepositoryTests.cs @@ -57,7 +57,7 @@ public async Task ShouldFilterAndOrder() false); var retrievedPosts = blogPosts.ToList(); - retrievedPosts.Any(b => b.Id == filteredOutPost.Id).Should().BeFalse(); + retrievedPosts.Exists(b => b.Id == filteredOutPost.Id).Should().BeFalse(); retrievedPosts[0].Id.Should().Be(olderPost.Id); retrievedPosts[1].Id.Should().Be(newerPost.Id); }