Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore directives that are commented out #324

Open
BenLloydPearson opened this issue Sep 19, 2023 · 2 comments
Open

Ignore directives that are commented out #324

BenLloydPearson opened this issue Sep 19, 2023 · 2 comments
Labels
enhancement New feature or request roadmap

Comments

@BenLloydPearson
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
If you comment out a directive inside an if: statement, that directive will still be run. Any directive lines that are preceded by a # should probably be ignored.

Describe the solution you'd like
Any configuration file lines that start with a # should be ignored.

Describe alternatives you've considered
You need to move the line to a place where it won't be run or delete it entirely.

Additional context
Reported here: #317 (comment)

@BenLloydPearson
Copy link
Collaborator Author

@PavelLinearB Related to this, I discovered that all items inside {{ }} will be treated as templates when they are inside comments. I suspect this may be a nunjucks behavior.

@BenLloydPearson
Copy link
Collaborator Author

The Jjinja docs indicate that comments should be structured like this {# comment #}. We'll need to investigate if this works in gitStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap
Projects
None yet
Development

No branches or pull requests

2 participants