Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit result in TMailContact/autocomplete #3408

Open
hoangdat opened this issue Jan 7, 2025 · 5 comments
Open

Remove limit result in TMailContact/autocomplete #3408

hoangdat opened this issue Jan 7, 2025 · 5 comments
Assignees
Labels

Comments

@hoangdat
Copy link
Member

hoangdat commented Jan 7, 2025

Desc:

https://github.com/Yash18-hub/CISD-GES/issues/132

Customer don't want to have limitation in auto complete response.
Front-end hardcoded 5 in limit when no specific limit.

@chibenwa

@chibenwa
Copy link
Member

chibenwa commented Jan 7, 2025

Unlimited is technically not doable on top of Elasticsearch.

Maybe:

  • Increase the count to 8
  • Have a button at the bottom to load more results ?

@hoangdat
Copy link
Member Author

Have a button at the bottom to load more results ?

So back-end need to support paging request. WDYT? @chibenwa @Arsnael

@Arsnael
Copy link
Member

Arsnael commented Jan 13, 2025

So back-end need to support paging request. WDYT? @chibenwa @Arsnael

Limit when not defined is 256 by default. Could this be enough? If there is a need for pagination or an offset then yes we might need to do some work on the back then, those aint supported atm

@chibenwa
Copy link
Member

Limit when not defined is 256 by default. Could this be enough?

I think so!

@hoangdat
Copy link
Member Author

  • to make auto complete smooth, still have limit = 8,
  • detect user scroll to the last item, trigger load more with limit = 256
  • keep transition smooth as load more (8 first items must be not changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants