Undefined token in Api Tests

[dreamsbond]

Hi @neomerx.

I found the OAuthLoginTrait does not properly returning token based on corresponding role of user, says "admin", etc...

[neomerx]

Default application uses Faker to populate the database with some data. The data are originally random though until you change seed script it will have

• '[email protected]' as an admin email
• '[email protected]' as a moderator email
• '[email protected]' as a user email

And here are default methods with those default emails/passwords to have API tokens.

If you modify migrations/seeds you obviously need to make some changes in the login trait. The actual changes are application specific.

[dreamsbond]

    /**
     * @param string $username
     * @param string $password
     *
     * @return string
     */
    private function requestOAuthToken(string $username, string $password): string
    {
        /** @var ResponseInterface $response */
        $response = $this->post('/token', [
            'grant_type' => 'password',
            'username'   => $username,
            'password'   => $password,
        ]);

        assert($response->getStatusCode() == 200);
        assert(($token = json_decode((string)$response->getBody())) !== false);

        $value = $token->access_token;
        assert(empty($value) === false);

        return $value;
    }

tested out $token was not assigned
in

assert(($token = json_decode((string)$response->getBody())) !== false);

and therefore getAdminOAuthToken failed

[neomerx]

What are the inputs (username, password)? Does it work with the default app?

[dreamsbond]

both default faker seeded username and password and;
self-defined username and password works by

replacing

assert(($token = json_decode((string)$response->getBody())) !== false);

with

        $token = json_decode((string)$response->getBody());
        assert($token !== false);

in OAuthLoginTrait

[neomerx]

I took default app, run migration and seed then changed CommentApiTest line 13 as below and added lines 22-23. Token seems to work 🤷‍♂️

Can you please clone the default app and commit changes that show the issue?

[dreamsbond]

default app cloned.

seems does not help.

PHPUnit 6.5.7 by Sebastian Bergmann and contributors.


Undefined variable: token

[neomerx]

• I created a new project composer create-project --prefer-dist limoncello-php/app app_name (on install it runs migrations and seeds).
• I opened the newly created project in IDE and run tests successfully.
• opened \Tests\Api\UserApiTest::testIndex, added use for OAuthLoginTrait and $token = $this->requestOAuthToken('[email protected]', UsersSeed::DEFAULT_PASSWORD);
• put a breakpoint & run debugger
• 🤷‍♂️