-
Notifications
You must be signed in to change notification settings - Fork 12
Description
Up front: thanks for creating this project. It's exactly what's needed for starting a well-structured, enterprise-level Lambda. Kudos for doing this.
Some of the configuration files, however, have me confused.
Copying .env.example to .env and making changes to it (change ENVIRONMENT to develop and MESSAGE_QUEUE_URL to my queue in AWS) seems to work when running locally. When I deploy that to AWS, however, MESSAGE_QUEUE_URL gets set to [myId]/serverless-express-typescript-sqs-develop-MessagesQueue-[someGUID}, which gets created for me. I'm not sure how to fix that other than changing that env var after the lambda gets created.
I would have expected multiple .env files to be available and switch between them depending on what I wanted to deploy, but I don't think that that's going on here. Maybe it is? It seems like we have to configure that file, then deploy with a command that matches the environment specified in .env. I'm thinking that I'm missing something here.
secrets.yml doesn't seem to be the place to store secrets, right? It seems to be a mapping of environment names. That's confusing.
Typos in your readme:
- secrects should be secrets
- there's a trailing \s on one of your aws lambda invoke lines
Also note that your region is hardcoded in serverless.yml.
Thanks again for creating this. Awesome work that's helped dramatically.