Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate duplicate events #8

Open
lilhoser opened this issue Sep 28, 2023 · 0 comments
Open

Investigate duplicate events #8

lilhoser opened this issue Sep 28, 2023 · 0 comments

Comments

@lilhoser
Copy link
Owner

in providerParser.cs:GetManifest - see decoding guid in https://learn.microsoft.com/en-us/windows/win32/api/evntcons/ne-evntcons-etw_provider_trait_type

		//
                // TODO: Research this condition. Rarely, a provider will have
                // seemingly duplicate events.
                //
                // Debug.Assert(!parsedManifest.Events.Contains(manifestEvent));

also applies to ParsedEtwManifestEvent.cs equality comparison:

		//
		// According to https://learn.microsoft.com/en-us/windows/win32/api/evntprov/ns-evntprov-event_descriptor
		//          "For manifest-based ETW, the combination Provider.DecodeGuid +
		//          Event.Id + Event.Version should uniquely identify an event"
		// I have seen cases where event IDs + version for a given provider is not enough,
		// but adding in opcode is. Not sure if "decoding GUID" comes from provider traits
		// and thus has another level of indirection to determine uniqueness.
		//
		return Id == Other.Id && Version == Other.Version &&
			Opcode == Other.Opcode;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant