Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Null Values from transaction logs #6

Open
Dassy23 opened this issue Feb 1, 2022 · 6 comments
Open

Getting Null Values from transaction logs #6

Dassy23 opened this issue Feb 1, 2022 · 6 comments

Comments

@Dassy23
Copy link

Dassy23 commented Feb 1, 2022

Appears that transaction logs are not being saved to the database

@lijunwangs
Copy link
Owner

Can you elaborate what is Null values? Do you see any records in the transaction table?

@Dassy23
Copy link
Author

Dassy23 commented Feb 1, 2022

No records in the transactions table when running the query SELECT (meta).log_messages FROM transaction

@lijunwangs
Copy link
Owner

Thanks for reporting this issue -- I will look into this as a priority.

@lijunwangs
Copy link
Owner

@Dassy23 -- can you try add the following arguments in your validator command line as a workaround?

--enable-cpi-and-log-storage --enable-rpc-transaction-history

I will make a change to support it without requiring these args.

@lijunwangs
Copy link
Owner

This issue seems to be caused by a recent change:

45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1434) if !self.enable_cpi_and_log_storage {
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1435) execution_results.iter_mut().for_each(|execution_result| {
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1436) if let TransactionExecutionResult::Executed(details) = execution_result {
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1437) details.log_messages.take();
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1438) details.inner_instructions.take();
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1439) }
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1440) });
45458e71393 ledger/src/blockstore_processor.rs (Justin Starry 2022-01-05 10:15:15 +0800 1441) }

@Dassy23
Copy link
Author

Dassy23 commented Feb 1, 2022

Thanks for the quick response on this @lijunwangs

lijunwangs added a commit to solana-labs/solana that referenced this issue Feb 12, 2022
Transaction logs are not being saved to the database through the plugin interface.

Summary of Changes

Retain the transaction logs when transaction notification plugin is loaded.

Fixes #
lijunwangs/solana-accountsdb-plugin-postgres#6
jeffwashington pushed a commit to jeffwashington/solana that referenced this issue Feb 24, 2022
…-labs#22874)

Transaction logs are not being saved to the database through the plugin interface.

Summary of Changes

Retain the transaction logs when transaction notification plugin is loaded.

Fixes #
lijunwangs/solana-accountsdb-plugin-postgres#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants