Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slice regression caused by #32 #34

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fix slice regression caused by #32 #34

merged 1 commit into from
Sep 1, 2021

Conversation

simaotwx
Copy link
Contributor

@simaotwx simaotwx commented Sep 1, 2021

Slices that are nil are empty and valid.
The change introduced by #32 which fixes #31 has changed how
nil slices are marshaled (null instead of []).

Fix this regression by removing slices from the check.

@simaotwx
Fix slice regression caused by liip#32
0b23eee 
Slices that are nil are empty and valid.
The change introduced by liip#32 which fixes liip#31 has changed how
nil slices are marshaled (`null` instead of `[]`).

Fix this regression by removing slices from the check.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.615% when pulling 0b23eee on simaotwx:bugfix/31-addendum-no-slice into a143a78 on liip:master.

@mweibel mweibel merged commit cd01545 into liip:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when serializing null pointers
3 participants
@simaotwx @coveralls @mweibel