-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic when serializing null pointers #31
Comments
without testing your change, this looks more or less right (use |
fixed via #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello I think there is an issue in the serialization process because when we serialize this kind of struct :
Via :
Panic occurs here at sheriff.go line 222 :
It looks like when the value is a Ptr, sheriff tries to dereference it and then get it's value, but if the Ptr is nil then it dereferences a nil.
Tell me if I'm wrong but a safe fix for this could be :
The text was updated successfully, but these errors were encountered: