Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address deprecation of Publication.name #270

Open
isaacbowen opened this issue Aug 10, 2023 · 6 comments
Open

address deprecation of Publication.name #270

isaacbowen opened this issue Aug 10, 2023 · 6 comments

Comments

@isaacbowen
Copy link
Member

Concerning Publication.title, Shopify says:

Name of the publication. Use Catalog.title instead.

The task library uses publications in many places. (As an example, this issue came up re: Auto-tag customers by sales channel.)

Screenshot 2023-08-10 at 8 41 56 AM
@isaacbowen
Copy link
Member Author

@tekhaus do you have space to look this over?

@tekhaus
Copy link
Collaborator

tekhaus commented Aug 10, 2023

Catalog currently returns null on the order resource (notice the unstable api in their deprecation notice even). So this would be a bit of a workaround (see linked slack thread) to put in place for all of those tasks. And of course Shopify then might come back and fix the bug.

https://shopifypartners.slack.com/archives/CB9K9FDTJ/p1681835379562709

Thoughts?

@tekhaus
Copy link
Collaborator

tekhaus commented Oct 11, 2023

Update: as of 2023-10, the catalog field still returns nulls on the publication resource. The only known way to get the catalog to publication mapping is by iterating over the catalogs connection and checking the paired publication ID.

This is likely moot anyways, as here are some example catalog titles for their respective publication names:

  • Online Store => Channel Catalog 81408557304 b62267ac-94b2-442f-86bb-5316e90be94e
  • Point of Sale => Channel Catalog 81952997624 afd408f2-4181-4831-b5bb-2613bbe802ff

Clearly, using those esoteric catalog titles in task configuration fields is not ideal, and without access to the API, I don't believe a merchant would be able to retrieve the catalog titles anyways.

Another interesting thing about this deprecation notice is that it does not include a "resolve by" date, so it's unknown how long this can be deferred.

I'll likely switch the relevant tasks to use the publication ID instead, but first I'll need to research how a merchant would be able to get this ID from the admin UI.

@tekhaus
Copy link
Collaborator

tekhaus commented Dec 20, 2023

Update: waiting to see what 2024-01 API will bring.

Turns out the only way (currently) for a merchant to get the publication ID of sales channels from the admin UI, is to open the sales channels modal, view the page source, and search for "Online Store" etc.

@tekhaus
Copy link
Collaborator

tekhaus commented Jan 2, 2024

Update: no updates in the 2024-01 API except that now the resolution deadline has been set for 2024-10. Recommend suppressing this deprecation until 2024-07 release.

@tekhaus
Copy link
Collaborator

tekhaus commented Jul 19, 2024

Update: nothing changed as of 2024-07 API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants