From 1a543fbfcd328059bc054d9a78362e5e7bf51c91 Mon Sep 17 00:00:00 2001 From: ziggie Date: Wed, 10 Dec 2025 09:35:08 +0100 Subject: [PATCH 1/2] routerrpc: fix payment address deep copy using copy for a slice of size 0 will not copy anything so we need to first initialize the slice before we do the deep copy. (cherry picked from commit 1c4bcc3b7dba14ed52c69f4b7041bd431d528c49) --- lnrpc/routerrpc/router_server.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lnrpc/routerrpc/router_server.go b/lnrpc/routerrpc/router_server.go index db04526d487..27cd85824f5 100644 --- a/lnrpc/routerrpc/router_server.go +++ b/lnrpc/routerrpc/router_server.go @@ -557,6 +557,7 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string, // If the payment addresses is specified, then we'll also populate that // now as well. payReq.PaymentAddr.WhenSome(func(addr [32]byte) { + probeRequest.PaymentAddr = make([]byte, lntypes.HashSize) copy(probeRequest.PaymentAddr, addr[:]) }) @@ -624,6 +625,10 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string, // Copy the payment address if present. if len(probeRequest.PaymentAddr) > 0 { + lspProbeRequest.PaymentAddr = make( + []byte, lntypes.HashSize, + ) + copy( lspProbeRequest.PaymentAddr, probeRequest.PaymentAddr, From f82c35c77741835bb2df5b82d9663c6779276e6c Mon Sep 17 00:00:00 2001 From: ziggie Date: Wed, 10 Dec 2025 09:39:43 +0100 Subject: [PATCH 2/2] docs: add release-notes for LND 20.1 (cherry picked from commit ac30443cc19b0213912bc704462ddf5af7feae50) --- docs/release-notes/release-notes-0.20.1.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/release-notes/release-notes-0.20.1.md b/docs/release-notes/release-notes-0.20.1.md index b679958c845..ee76c6f4d6b 100644 --- a/docs/release-notes/release-notes-0.20.1.md +++ b/docs/release-notes/release-notes-0.20.1.md @@ -59,6 +59,11 @@ issue](https://github.com/lightningnetwork/lnd/pull/10428) in LND which might happen when running postgres with a limited number of connections configured. +* [Add missing payment address/secret when probing an + invoice](https://github.com/lightningnetwork/lnd/pull/10439). This makes sure + the EstimateRouteFee API can probe Eclair and LDK nodes which enforce the + payment address/secret. + # New Features ## Functional Enhancements