[Custom Transactions] Add TxBuilder trait, support fixed additional outputs
#3775
Conversation
|
👋 Thanks for assigning @carlaKC as a reviewer! |
tankyleo
force-pushed
the
fixed-addl-outputs
branch
from
c245ca1 to
7fc2092
Compare
tankyleo
force-pushed
the
fixed-addl-outputs
branch
from
7fc2092 to
6aa0848
Compare
tankyleo
force-pushed
the
fixed-addl-outputs
branch
from
fa3ea56 to
14b83a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
+ Coverage 89.53% 90.37% +0.84%
==========================================
Files 157 160 +3
Lines 125310 133578 +8268
Branches 125310 133578 +8268
==========================================
+ Hits 112192 120721 +8529
+ Misses 10429 10231 -198
+ Partials 2689 2626 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
lightning/src/ln/channel.rs
Outdated
| @@ -3933,11 +3932,23 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider { | |||
| let total_fee_sat = commit_tx_fee_sat(feerate_per_kw, non_dust_htlc_count, &funding.channel_transaction_parameters.channel_type_features); | |||
| let total_anchors_sat = if funding.channel_transaction_parameters.channel_type_features.supports_anchors_zero_fee_htlc_tx() { ANCHOR_OUTPUT_VALUE_SATOSHI * 2 } else { 0 }; | |||
|
|
|||
| // We MUST use saturating subs here, as the funder's balance is not guaranteed to be greater | |||
There was a problem hiding this comment.
Pre-existing, but noticed this during review: #3815
Doesn't seem like a big deal, but thought it could be relevant here!
|
🔔 4th Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
hi @TheBlueMatt on this branch here i make an attempt at an API that supports "fixed additional outputs" on commitment transactions.
I place today's 330 sat anchors in that bucket, but the API should allow for custom ones.
The API should also let people customize all the existing outputs on the commitment transaction.
Still need to think about any remaining TODOs for additional outputs that are only present for some commitments (eg. DLC outputs), depending on how we'd like to prioritize these.
One TODO that remains is abstracting away the calls to
chan_utils::commit_and_htlc_tx_fees_satin channel dust exposure calculations.