Mypy is failing while checking finetune_eval.py

[vectorvp]

As long as there is duplicated naming of finetune_eval in benchmarks/imagenet/resnet50/finetune_eval.py and benchmarks/imagenet/vitb16/finetune_eval.py mypy throws an exception when running pre-commit run --all-files:

benchmarks/imagenet/vitb16/finetune_eval.py: error: Duplicate module named "finetune_eval" (also at "benchmarks/imagenet/resnet50/finetune_eval.py")
benchmarks/imagenet/vitb16/finetune_eval.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
benchmarks/imagenet/vitb16/finetune_eval.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

There are 3 solutions:

• Change the namings;
• Add init.py to form packages;
• Add the workaround to contributing manual.

[guarin]

Thanks for raising the issue! Mypy should actually only check the src and tests directories. This seems like an error in the pre-commit configuration

[vectorvp]

@guarin, as long as there is no src, I think it should be configured to check only tests. I will make a PR to fix this.

[gurain]

，只要没有 src，我觉得应该配置成只检查 tests。我将制作一个 PR 来解决这个问题。

haha, friend, you quoted the wrong person

[vectorvp]

@gurain, 对不起！

[vectorvp]

@guarin, if I set mypy to analyze only tests it throws a lot of error from this folder. If I understand correctly you have a TODO in pyproject.toml to empty the exclude list. I can take some files from there and exclude them one by one if it is OK.

[guarin]

Hi, yes we have an issue to increase typing coverage: #1635

[vectorvp]

@guarin, great, I will work on it.