Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup docstrings in lightly/models/modules subpackage. #1687

Open
Tracked by #1216
guarin opened this issue Oct 9, 2024 · 10 comments
Open
Tracked by #1216

Cleanup docstrings in lightly/models/modules subpackage. #1687

guarin opened this issue Oct 9, 2024 · 10 comments

Comments

@guarin
Copy link
Contributor

guarin commented Oct 9, 2024

See #1216 for more information

@goelnaman66
Copy link

Hii, can you assign this to me?

@guarin
Copy link
Contributor Author

guarin commented Oct 9, 2024

Hi, yes of course :)

@Abhrajitdas02
Copy link

hii, can you ssign this issue to me?

@guarin
Copy link
Contributor Author

guarin commented Oct 14, 2024

Hi @Abhrajitdas02! Thanks for your interest in this issue. We only assign issues to one person at a time.

@goelnaman66 did you already have time to look into this?

@fadkeabhi
Copy link
Contributor

Hey @guarin I would like to work on this issue as discussed here #1216. For some reason I did not receive the notification about it and I could not comment on it, can you assign it to me now. I have already started to work on it.

@ayush22iitbhu
Copy link
Contributor

@guarin I see this issue has been open for more than a week. I have already started working on this. Also, I have already completed the work you assigned to me on documentation of lightly/models/utils.py and lightly/loss subpackage. Please assign this issue to me. I'll complete this soon as well.

@guarin
Copy link
Contributor Author

guarin commented Oct 17, 2024

Hi @fadkeabhi and @ayush22iitbhu could you post which files you already updated? Then we can avoid that you work both on the same thing.

@ayush22iitbhu
Copy link
Contributor

@guarin I have already updated center.py, heads.py, heads_timm.py and currently working on ijepa.py. But you can assign more files to me.

@guarin
Copy link
Contributor Author

guarin commented Oct 17, 2024

Could you already make a PR for these files? Then we can merge and avoid conflicts later on. The fewer files a PR touches the easier it is to merge for us :)

@ayush22iitbhu
Copy link
Contributor

@guarin review PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants