Use sequential ID generation for messages

Some cloud related processes are starting to make
some assumptions that we generally submit messages
with sequential message IDs, indicating either the
order that data was collected in, or the order it
perhaps should be used in.
So remove any hints of random ID generation, even if
custom apps might choose to use it for some reason,
we will stick to sequential.

Author: addshore

src/modules/comms/comms.toit

@@ -3,7 +3,7 @@ import ...devices as devices
 import ...messages as messages
 import ...util.docs show message-bytes-to-docs-url
 import ...util.resilience show catch-and-restart
-import ...util.idgen show IdGenerator RandomIdGenerator SequentialIdGenerator
+import ...util.idgen show IdGenerator SequentialIdGenerator
 import ...util.bytes show stringify-all-bytes byte-array-to-list
 import .message-handler show MessageHandler
 import io.reader show Reader
@@ -46,8 +46,8 @@ class Comms:
       // Allow passing in handlers to register on creation
       --handlers/List?/*<MessageHandler>*/ = []
       // Customizable id generator for message ids
-      // Defaults to a random uint32 generator
-      --idGenerator/IdGenerator = (RandomIdGenerator --lowerBound=1 --upperBound=4_294_967_295)
+      // Defaults to a sequential generator starting at 1, max 4_294_967_295 (uint32 max)
+      --idGenerator/IdGenerator = (SequentialIdGenerator --start=1 --maxId=4_294_967_295)
       --startInbound/bool = true // Start the inbound reader (polling the device on I2C for messages)
       --open/bool = true // Send Open message and heartbeats to keep connection alive
       --reinitOnStart/bool = true // Reinitialize the device on start. Clearing buffers and subscriptions. Primarily for high throughput cases.

src/protocol/message.toit

@@ -40,11 +40,6 @@ class Message:
   msg.header.data.add-data-uint8 Header.TYPE-MESSAGE-METHOD method
   return msg
 
- with-random-msg-id -> Message:
-  randomUint32 := ( random 4_294_967_295) +1
-  header.data.add-data-uint32 Header.TYPE_MESSAGE_ID randomUint32
-  return this
-
  msgId -> int?:
   if header.data.has-data Header.TYPE_MESSAGE_ID: return header.data.get-data-uint Header.TYPE_MESSAGE_ID
   return null

src/util/idgen.toit

@@ -11,15 +11,4 @@ class SequentialIdGenerator implements IdGenerator:
 
   next -> int:
     nextId_ = (nextId_ + 1) % maxId_
-    return nextId_
-
-class RandomIdGenerator implements IdGenerator:
-  lowerBound_ := 0
-  upperBound_ := 0
-
-  constructor --lowerBound/int --upperBound/int:
-    lowerBound_ = lowerBound
-    upperBound_ = upperBound
-  
-  next -> int:
-    return random lowerBound_ upperBound_
+    return nextId_

tests/util/idgen.test.toit

@@ -2,7 +2,6 @@ import lightbug.util.idgen
 
 main:
   sequential
-  random
 
 sequential:
   g := idgen.SequentialIdGenerator --start=1 --maxId=3
@@ -13,12 +12,3 @@ sequential:
       print "❌ idgen sequential Wanted $it got $i"
     else:
       print "✅ idgen sequential Got $i"
-
-random:
-  g := idgen.RandomIdGenerator --lowerBound=1 --upperBound=3
-  for i := 0; i < 10; i++:
-    it := g.next
-    if it < 1 or it > 3:
-      print "❌ idgen random Out of bounds $it"
-    else:
-      print "✅ idgen random Got $it (in bounds)"