Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If*** can use their query expression counterparts #65

Open
bserdar opened this issue Oct 17, 2014 · 0 comments
Open

If*** can use their query expression counterparts #65

bserdar opened this issue Oct 17, 2014 · 0 comments

Comments

@bserdar
Copy link
Contributor

bserdar commented Oct 17, 2014

For instance, IfFieldCheckField declares a field, op, and rfield. Then it deals with to-from string translation, parsing, etc. All these are already implemented in QueryExpression classes, and those should be used instead. That is, in IfFieldCheckField, instead of declaring field, rfield, and op, declare a FieldComparisonExpression. IfFieldCheckValue can use ValueComparisonExpression, IfFieldCheckValues can use NaryRelationalExpression, regex can use RegexExpression...etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant