Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade: Add thread pool for Lightblue calls to protect system resources #381

Open
paterczm opened this issue Jun 21, 2016 · 0 comments
Open

Comments

@paterczm
Copy link
Contributor

Should we restore thread pools? It was established that they are not responsible for the recent outages. Note that interrupting timed out threads should mitigate the issue thread pools are supposed to solve.

If we do restore thread pools, then we should ensure clean pool shutdown when application is undeployed (#350 doesn't do this, because it doesn't know application lifecycle). There are edge cases where this can cause problems and is especially dangerous during outage, when admin acts fast, not necessarily following all procedures, and the java.lang.OutOfMemoryError can send his investigation in a wrong direction. It happened to me in stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant