Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facade RFE: conditional consistency check ignores #373

Open
dcrissman opened this issue Jun 6, 2016 · 4 comments
Open

facade RFE: conditional consistency check ignores #373

dcrissman opened this issue Jun 6, 2016 · 4 comments

Comments

@dcrissman
Copy link
Member

Say you decided to not migrate over certain data points to lightblue for whatever reason. Maybe certain rows were deactivated in the old system and there is no need to carry them forward, perhaps denoted by a boolean or byte flag column in the legacy data source. In this scenario, you would get a data inconsistency every time the deactivated row was referenced. Would it be possible to disable the consistency check based on that boolean column in the legacy data source?

@paterczm
Copy link
Contributor

paterczm commented Jun 6, 2016

To make this solution generic, we would need some sort of a rule engine to decide when not to do a consistency check. That is a lot of complexity.

@dcrissman
Copy link
Member Author

What if we created a new class level annotation that took an OGNL expression, then in the ConsistencyChecker.checkConsistency method we use the expression to validate the legacyEntity using reflection. If the check fails, simply return false.

@paterczm
Copy link
Contributor

This is doable, though a significant level of effort. So far we have only one case where we'd like to ignore consistency check based on values rather than data structure, right?

@dcrissman
Copy link
Member Author

Yes, just one case.

I did some preliminary investigation/work and I agree that the effort would be fairly significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants