Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facade: start timeout for LB calls after oracle call returns #369

Open
bserdar opened this issue May 31, 2016 · 3 comments
Open

facade: start timeout for LB calls after oracle call returns #369

bserdar opened this issue May 31, 2016 · 3 comments

Comments

@bserdar
Copy link
Contributor

bserdar commented May 31, 2016

When both LB and oracle calls are started at the same time, applying a 2sec timeout to LB calls is not fair when oracle call takes longer to complete. Instead, the 2 sec timeout should start after oracle call returns. I think if we issue LB call on a separate thread, then issue the oracle call, and when oracle call returns wait for 2 secs before logging a slow call, this can be done.

@paterczm
Copy link
Contributor

paterczm commented Jun 1, 2016

I agree and I think I know how to implement it, after dealing with initial confusion. How about max(2s, ) instead of +2s?

We can also try to interrupt the tread after timeout using https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Future.html#cancel(boolean).

@paterczm
Copy link
Contributor

paterczm commented Jun 1, 2016

#370

@paterczm
Copy link
Contributor

paterczm commented Jun 1, 2016

#371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants