Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce hook memory footprint #802

Closed
paterczm opened this issue Jul 20, 2017 · 1 comment
Closed

Reduce hook memory footprint #802

paterczm opened this issue Jul 20, 2017 · 1 comment
Labels
enhancement

Comments

@paterczm
Copy link
Contributor

HookManager makes copies of documents (pre and post). Those copies are needed to pass to the hook implementations. The problem is that it can triple the amount of data stored in memory - in case of updates and saves, we have the document which is being returned to the client, document before update (pre) and document after update (post).

Processing hooks in batches or as a stream could solve this problem.
@paterczm
Copy link
Contributor Author

Duplicate of lightblue-platform/lightblue-mongo#378.

paterczm pushed a commit that referenced this issue Jul 24, 2017
Enformce memory consumption limit on hook queuing (band aid solution …
e26d7f3 
…until #802)
@paterczm paterczm mentioned this issue Jul 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paterczm