Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noMatchCount paramter to requests #789

Open
paterczm opened this issue Jun 6, 2017 · 2 comments
Open

Add noMatchCount paramter to requests #789

paterczm opened this issue Jun 6, 2017 · 2 comments

Comments

@paterczm
Copy link
Contributor

paterczm commented Jun 6, 2017

cursor.count() operation can be expensive. Make it optional. By default, it should work as before (i.e. return count). For new streaming apis, which are not used by anyone yet, we can default to the less expensive noMatchCount: true.

@paterczm
Copy link
Contributor Author

paterczm commented Jun 7, 2017

When writeConcern: unacknowledged is used, Lightblue fails with "Can not get information about an unacknowledged write", because Lightblue needs to check modified count. So it'd be good to have that flag for all counts, not just match.

@paterczm
Copy link
Contributor Author

We can make the java lightblue-client not request the match count by default and refactor the apis so that anyone using the match count will get a compilation error (this is when they should realize they need to set noMatchCount: false). This will allow us to minimize the match count overhead without creating a risk of runtime errors for the clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant