-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absence of signal is not detected as offline #294
Comments
We're using a simple approach to check connectivity which may be not enough, especially on android,. References:
We need to improve detection and maybe not rely only on connectivity plugin changes only, but trigger another connectivity check upon request timeout. |
I think that a simple 5-10 timeout that triggers offline mode could be a simple solution. Maybe later a more robust solution could be implemented as you suggested. |
Do you still reproduce the issue @S1M0N38 ? |
I've disable Wi-Fi and Mobile Data. I've enter the app and I can use all the offline features in the app. However the original issue was about not connection at all (no cellular connection). Right now I don't know how to easily reproduce such situation. I think I have to go to some place without connection (e.g. mountain) or maybe in a Faraday cage (e.g. an elevator). When I'm in a place able to reproduce this network status, I will update this issue. |
If you have a method with clear steps to reproduce, please share it. Thanks! |
On a physical device:
I know that this is a minor issue but I think it's reasonable to think that when there is no signal the app should behave like the airplane mode is on. I restate that when the airplane mode is active offline features work as expected. |
Ok, thank you. Indeed it should behave like airplane mode, after a timeout. We should now try to reproduce this signal loss programmatically to ensure a fix is working. |
If I put my Android phone in airplane mode, I'm able to use the offline features of the app.
However, if there is no connection at all, the app tries to connect to servers, and the app becomes unusable.
Is that intentional?
(Edit: maybe duplicate issue. PR #226)
The text was updated successfully, but these errors were encountered: