Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absence of signal is not detected as offline #294

Open
S1M0N38 opened this issue Aug 22, 2023 · 8 comments
Open

Absence of signal is not detected as offline #294

S1M0N38 opened this issue Aug 22, 2023 · 8 comments
Labels
bug Something isn't working cat: data State management, data modelling, etc. Not related to UI. cat: offline For all features that should work offline
Milestone

Comments

@S1M0N38
Copy link

S1M0N38 commented Aug 22, 2023

If I put my Android phone in airplane mode, I'm able to use the offline features of the app.
ok

However, if there is no connection at all, the app tries to connect to servers, and the app becomes unusable.
notok

Is that intentional?

(Edit: maybe duplicate issue. PR #226)

@veloce
Copy link
Contributor

veloce commented Aug 22, 2023

We're using a simple approach to check connectivity which may be not enough, especially on android,.

References:

We need to improve detection and maybe not rely only on connectivity plugin changes only, but trigger another connectivity check upon request timeout.

@S1M0N38
Copy link
Author

S1M0N38 commented Aug 23, 2023

I think that a simple 5-10 timeout that triggers offline mode could be a simple solution. Maybe later a more robust solution could be implemented as you suggested.

@veloce
Copy link
Contributor

veloce commented Jan 3, 2024

Do you still reproduce the issue @S1M0N38 ?

@veloce veloce added the bug Something isn't working label Jan 3, 2024
@S1M0N38
Copy link
Author

S1M0N38 commented Jan 3, 2024

I've disable Wi-Fi and Mobile Data. I've enter the app and I can use all the offline features in the app.

However the original issue was about not connection at all (no cellular connection). Right now I don't know how to easily reproduce such situation. I think I have to go to some place without connection (e.g. mountain) or maybe in a Faraday cage (e.g. an elevator).

When I'm in a place able to reproduce this network status, I will update this issue.

@S1M0N38
Copy link
Author

S1M0N38 commented Jan 7, 2024

puzzles.jpg

I was able to reproduce the issue on version 0.6.9

@veloce
Copy link
Contributor

veloce commented Jan 9, 2024

If you have a method with clear steps to reproduce, please share it. Thanks!

@S1M0N38
Copy link
Author

S1M0N38 commented Jan 9, 2024

On a physical device:

  1. I've turn on Mobile Data (e.g. 4G or 5G)
  2. Reach for a place where there is no signal (I've been in the mountain)
  3. Open the Lichess app v2
  4. Navigate the app

I know that this is a minor issue but I think it's reasonable to think that when there is no signal the app should behave like the airplane mode is on. I restate that when the airplane mode is active offline features work as expected.

@veloce veloce modified the milestones: Launch, Beta 2 Jan 10, 2024
@veloce
Copy link
Contributor

veloce commented Jan 10, 2024

Ok, thank you. Indeed it should behave like airplane mode, after a timeout. We should now try to reproduce this signal loss programmatically to ensure a fix is working.

@veloce veloce added cat: data State management, data modelling, etc. Not related to UI. cat: offline For all features that should work offline labels Jan 10, 2024
@veloce veloce changed the title Airplane mode vs No connection Absence of signal is not detected as offline Jan 10, 2024
@veloce veloce modified the milestones: Alpha 2, Launch Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cat: data State management, data modelling, etc. Not related to UI. cat: offline For all features that should work offline
Projects
None yet
Development

No branches or pull requests

2 participants