Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and number formatting applied only after app restart #1127

Open
julien4215 opened this issue Nov 1, 2024 · 0 comments
Open

Date and number formatting applied only after app restart #1127

julien4215 opened this issue Nov 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@julien4215
Copy link
Contributor

What is the problem?

When a user changes the language, the formatting of dates and numbers is only applied after restarting the app.

Steps to reproduce the bug

  1. Go on the elo chart of a player
  2. Look at the date formatting locale
  3. Change the language in the settings
  4. Go back to the elo chart of a player
  5. Check that the date formatting locale did not change

App version

0.12.5

Device Info

Android 11

Additional information

This can be done like in this commit but setting the Intl.defaultLocale value when the user changes the language is probably the right way to do it.

@julien4215 julien4215 added the bug Something isn't working label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant