Adding v5 support

[petdance]

I've created a new v5 branch. Let's work against that, and use this ticket for discussion.

Why do you want to hide HTML::Tagset::v[45] from PAUSE? I don't think we do.

As to tests:

• Make a list of tags that are in v4 and not v5. Verify that. (font, i, center, etc)
• Make a list of tags that are in v5 and not v4. Verify that. (audio, video, mark, etc)
• Make a list of tags that are in both. Verify that. (table, div, etc)

We should probably test the differences in attributes. https://www.w3.org/TR/html5-diff/ notes, for example, "A new placeholder attribute can be specified on the input and textarea elements." I think it should be pretty exhaustive. We only have to do this once.

Finally, as I read it, you have v5 as the default, which is what we should do. We just need to make it dead simple, one line of code ideally, for someone to change back to v4 in their existing code.

[castaway]

I was hiding v4 / v5 just so we didnt have 3x lots of the essentially same docs, and was being lazy about just removing the POD.. I would class those modules as internal (tho I guess folks might want to load them instead of the top layer?)

Sounds good re test ideas, I'll have a poke tomorrow unless someone else gets to it.

Current default is v4, unless v5 is requested.. I'm happy with either variant .

[petdance]

I think v5 should be the default. If we're going to change the default, then the v5.0.0 release of the module is the time to do it. I think it's OK to break things in a big version leap like that, and HTML5 is what folks want in this day & age.

[castaway]

Makes sense to me

[castaway]

Btw in case it wasn't clear (and the labelling is somewhat misleading, I borrowed it from DBIx::Class) .. the technique doesn't hide the modules from PAUSE, but more from metacpan / cpan websites.

[castaway]

Looking at writing the tests of course makes me think of more things.. HTML5 has been through several iterations, some of which have added, then later removed, elements (grrr).. What approach should we take?

My initial thought would be:
a) Include all the HTML5 elements we can find, later removed or not (as I doubt writers of sites are updating everything as new changes come out)
b) Add another %isObseleted or similar which we attempt to keep uptodate with the removed ones? (would also include the removed v4 ones etc)

[petdance]

I guess I'm not seeing it as a problem to have the v4/v5 searchable in metacpan et al. I've removed them: 9d62e33

[petdance]

Do you have examples of things that were added to HTML5 and then removed? I didn't think there were any.

[castaway]

Do you have examples of things that were added to HTML5 and then removed? I didn't think there were any.

So far I've found "keygen" and "menuitem", from the mozilla obseleted list here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element (bottom of page)

[castaway]

Anything else we need to be doing?

[petdance]

I was under the impression you were still working on things. Did I misunderstand?

Right now I've got a v5 branch from what you've submitted so far, and I thought you were going to be adding more to it.

[castaway]

Oh, oops, miscommunication then. I was done after I submitted the tests update.

[petdance]

@castaway have you used this code anywhere? Have you used it with existing code that needs HTML::Tagset and tried it with the new 5.0.0?

[petdance]

I'm making the minimum version for HTML::Tagset be Perl 5.10.1, which came out in 2009.

[petdance]

I've cleaned up a bunch of stuff on formatting in the new files. All my changes have been pushed back to github on the v5 branch.

What else do we need to do in order to release it?