Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratios can be incorrect #20

Open
dankcushions opened this issue Aug 15, 2016 · 3 comments
Open

Aspect ratios can be incorrect #20

dankcushions opened this issue Aug 15, 2016 · 3 comments

Comments

@dankcushions
Copy link

This is the same issue as libretro/mame2003-libretro#51

The fix should be almost identical, but annoyingly the order this core executes is slightly different: here's where the fix should be: https://github.com/libretro/mame2010-libretro/blob/master/src/osd/retro/retromapper.c#L144

but the machine being run isn't initialised till after, here: https://github.com/libretro/mame2010-libretro/blob/master/src/osd/retro/retromain.c#L222
you need the driverindex, etc.

so really either the init needs to happen sooner, or the retro_av_info needs to be reset after the init.

Not sure I want to get stuck into this core so logging the issue.

@Voljega
Copy link

Voljega commented Apr 6, 2018

This issue is still existing today.
For instance, all CPS1 and CPS2 games are displayed with wrong aspect ratios

@Voljega
Copy link

Voljega commented Apr 23, 2018

Removing integer scaling correct the issues on all the games I tested so far

@dankcushions
Copy link
Author

yes integer scaling will cause problems, but I don't use it. this issue was happening with it turned off (however it may have since been fixed!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants