Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build problem with bsnes_accuracy bsnes_balance and bsnes_performace cores #1419

Open
scastilloml opened this issue May 21, 2020 · 3 comments

Comments

@scastilloml
Copy link

scastilloml commented May 21, 2020

Hi.

Yesterday, I built retroarch/libretro, under Debian 10, according to documentation at https://docs.libretro.com/development/retroarch/compilation/linux-and-bsd/

It goes well but some cores failed to build. One of them, desmume, needed pcap.h. Solved after installing libpcap0.8-dev.

I found other three cores that fail to build: bsnes_accuracy, bsnes_performance and bsnes_balanced.
Well, the cores are actually built. The problem is that there is a mismatch between the filename of the output of the compiler and the filename in the cp command that copy the cores to dist/unix.
In the case of bsnes_accurary the file built at libretro-bsnes_accuracy/out/ is bsnes2014_accuracy_libretro.so but the cp command try to copy bsnes_accuracy_libretro.so to dist/unix, so the cp command fails.

It happens that compiler output has 2014 in the filename, but copy command don't.

bsnes_balanced and bsnes_performance has the same problem.

I manually rename the file as a workaround. I'm not sure about what would be the right solution.

Regards and thank you.

@mase76
Copy link

mase76 commented Aug 21, 2020

I can confirm this issue. I also workarounded by renaming.

@scastilloml
Copy link
Author

I have checked tonight and the problem persists.

bsnes_accuracy, bsnes_performance and bsnes_balanced cores are successfully built but cp command to copy them to dist/unix fails because is trying to copy:

  • out/bsnes_accuracy_libretro.so instead of out/bsnes2014_accuracy_libretro.so
  • out/bsnes_performance_libretro.so instead of out/bsnes2014_performance_libretro.so
  • out/bsnes_balanced_libretro.so instead of out/bsnes2014_balanced_libretro.so

so libretro-build.sh count them as failed cores when they are succesfully built, but no copiet to dist/unix

Regards.

@zoltanvb
Copy link
Contributor

This one should be fixed by 7baba03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants