Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-libp2p tests failing in interop #364

Closed
MarcoPolo opened this issue May 22, 2024 · 5 comments · Fixed by #359
Closed

js-libp2p tests failing in interop #364

MarcoPolo opened this issue May 22, 2024 · 5 comments · Fixed by #359

Comments

@MarcoPolo
Copy link
Contributor

Not sure why yet, I haven't debugged this but I'm seeing every transport interop test with js-libp2p failing:

https://github.com/libp2p/test-plans/actions/runs/9182341165?pr=363
https://github.com/libp2p/test-plans/actions/runs/9182417914?pr=359
https://github.com/libp2p/go-libp2p/actions/runs/9181929857?pr=2807
https://github.com/libp2p/go-libp2p/actions/runs/9180086151?pr=2806
https://github.com/libp2p/go-libp2p/actions/runs/9179966225?pr=2805

I'll update here or in a PR as I learn more.

@MarcoPolo
Copy link
Contributor Author

MarcoPolo commented May 22, 2024

Works on my machine (of course) with the following steps:

  1. Checking out this repo
  2. (cd transport-interop/impl/js/v1.6 && make)
  3. npm ci
  4. ./node_modules/.bin/ts-node testplans.ts --name-filter="js -v1.6 x js-v1.6"

@diegomrsantos
Copy link
Contributor

could it be related to this libp2p/js-libp2p#2505 ?

@diegomrsantos
Copy link
Contributor

I can't reproduce this issue on my machine either.

@MarcoPolo
Copy link
Contributor Author

Unlikely to be related since it wouldn't explain why it happened suddenly.

I also pulled the exact image used by CI with:

curl https://s3.amazonaws.com/libp2p-by-tf-aws-bootstrap/imageCache/8d6bd5587fd7d648c4663358526240cb83225b8f7c4633854c17736b0b55892f-x86_64.tar.gz  | docker image load

and it still worked locally. I'm thinking this is something to do with the hosts and maybe the version of tools it's running.

@MarcoPolo
Copy link
Contributor Author

Fixed. See #359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants