rcmgr: expose resource limits to Prometheus #3433
Open
+201
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements TODO to report system limits to Prometheus metrics.
Previously, only resource usage was tracked in metrics, but the
configured limits were not exposed, making it difficult to understand
when resources were approaching their limits.
Changes:
- Add 'libp2p_rcmgr_limit' gauge metric with scope and resource labels
- Implement StatsTraceReporter.ReportSystemLimits() to export limits
- Report system and transient scope limits during initialization
- Export limits for memory, connections, streams, and file descriptors
- Add comprehensive tests for limits metrics
The new metric allows monitoring:
- Configured resource limits vs current usage
- Resource utilization percentages in dashboards
- Alert thresholds based on limit proximity
Example metrics exposed:
- libp2p_rcmgr_limit{scope="system",resource="memory"}
- libp2p_rcmgr_limit{scope="system",resource="conns"}
- libp2p_rcmgr_limit{scope="transient",resource="streams"}
Signed-off-by: sneax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements TODO to report system limits to Prometheus metrics. Previously, only resource usage was tracked in metrics, but the configured limits were not exposed, making it difficult to understand when resources were approaching their limits.
Changes:
The new metric allows monitoring:
Example metrics exposed: