New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Submodule.head_id if submodule isn't in superproject HEAD tree #1300

Merged

jdavid merged 1 commit into libgit2:master from jorio:submodule-head-id-null

Jun 3, 2024

Contributor

jorio commented Jun 3, 2024

When a submodule isn't in HEAD, git_submodule_head_id returns NULL.

pygit2's Submodule.head_id didn't check for ffi.NULL and built an Oid from garbage data in this case.


          Fix Submodule.head_id if submodule isn't in superproject HEAD tree

5182ce7

jdavid merged commit a9c7cce into libgit2:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet