Wrap libgit2 in a framework

[pietbrauer]

As dynamic frameworks are now supported across all platforms and issues are popping up in every other Xcode version regarding modular framework inclusion @phatblat had the idea to wrap libgit2 in a dynamic framework.

This issue is to discuss is as Twitter is not the right place to include everyone.

[phatblat]

I started work on this a while ago, keeping some notes in phatblat/pull/1 and overall the experiment was successful. I had a secondary goal of enabling Bitcode #529, but gave up as that is too much work with our current libssh2 and OpenSSL dependencies. Perhaps once libssh2 drops OpenSSL as a dependency.

I will start on some cleanup and move this into a branch here on the main repo where everyone can see and edit. I'd like to collapse the separate https://github.com/phatblat/git2 Xcode project into this one because it's not very big and that will make for less moving parts.

[pietbrauer]

I have a OpenSSL framework laying around if that is of any help? https://github.com/nerdishbynature/OpenSSL

[phatblat]

❤️

[pietbrauer]

Maybe something like gyp can help generating Xcode projects for the source this way we can just use libgit2 as a submodule and generate the Xcode project from the source each time? We did something like that in MX3 not sure if it supports dynamic frameworks though.

[phatblat]

Interesting. I haven't seen a tool like gyp before. Looks like the manual work is in creating the .gyp file which would then be used to generate the Xcode project. Are there any tools to generate a .gyp file from a Makefile?

I'm not too concerned about maintaining an Xcode project for libgit2 as its contents are very likely to be understood by contributors to this project. I'm more concerned about maintaining a parallel build system for our other dependencies, but that's outside the scope of this PR.

[pietbrauer]

I don't know about the Makefile but it seems more maintainable than an own Xcode project.

[pietbrauer]

I can try and get something working with libgit2.

[phatblat]

I've got a working project which is in a separate repo: https://github.com/phatblat/git2. I created it separate from ObjectiveGit thinking both it and SwiftGit2 could consume it. Since SwiftGit2 has stalled, it would be simpler if the project were here in the same repo as ObjectiveGit. Open to other opinions.

[phatblat]

It would be good to know if gym would make the project maintenance easier.

[pietbrauer]

Yep using that, just with gyp so we can keep the submodules?

[phatblat]

Do you mean keep git2 as a submodule?

[pietbrauer]

What the framework target should do is just take the source files and compile them into a dynamic framework right? Gyp takes all the files in a directory, takes the files from the include directory and makes a project out of it. Not sure if it supports framework targets yet so have to find out but maintaining a directory is easier than maintaining an Xcode project.