Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone and Init should take in RepositoryOptions #263

Closed
haacked opened this issue Dec 4, 2012 · 6 comments
Closed

Clone and Init should take in RepositoryOptions #263

haacked opened this issue Dec 4, 2012 · 6 comments
Labels
Milestone

Comments

@haacked
Copy link
Contributor

haacked commented Dec 4, 2012

The Repository ctor has an optional argument RepositoryOptions. However, there's a couple of places that create new instances of Repository and don't allow us to pass in a RepositoryOptions.

Repository.Init and Repository.Clone. They probably should. In our case, we need to pass in a custom global git config file path everywhere we use Repository.

@dougrathbone
Copy link

I'd also love a depth option for the clone (this probably isn't the right place to bring it up).

#229

@Saaman
Copy link
Contributor

Saaman commented Dec 14, 2012

I will work on this one...

@ben
Copy link
Member

ben commented Dec 14, 2012

Both of these are going to take some work in libgit2. I'm rounding up all the API-breaking changes over at libgit2/libgit2#1142; feel free to weigh in there.

@nulltoken
Copy link
Member

@haacked I think @Saaman's addition should fit your need ;-)

@haacked
Copy link
Contributor Author

haacked commented Jan 3, 2013

👍 This looks great! Thanks!

@nulltoken
Copy link
Member

Guys, sorry to dig up this thread, but I'd like you to peek at #453.

This new PR directly impacts back on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants