Use handle directly in ReleaseHandle

bording · bording · commit d1c26a30b037 · 2024-11-22T23:05:45.000-05:00
diff --git a/LibGit2Sharp/Core/Handles/Objects.cs b/LibGit2Sharp/Core/Handles/Objects.cs
@@ -18,7 +18,7 @@ internal TreeEntryHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_tree_entry_free((git_tree_entry*)AsIntPtr());
+            NativeMethods.git_tree_entry_free((git_tree_entry*)handle);
 
             return true;
         }
@@ -43,7 +43,7 @@ internal ReferenceHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_reference_free((git_reference*)AsIntPtr());
+            NativeMethods.git_reference_free((git_reference*)handle);
 
             return true;
         }
@@ -68,7 +68,7 @@ internal RepositoryHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_repository_free((git_repository*)AsIntPtr());
+            NativeMethods.git_repository_free((git_repository*)handle);
 
             return true;
         }
@@ -93,7 +93,7 @@ internal SignatureHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_signature_free((git_signature*)AsIntPtr());
+            NativeMethods.git_signature_free((git_signature*)handle);
 
             return true;
         }
@@ -118,7 +118,7 @@ internal StatusListHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_status_list_free((git_status_list*)AsIntPtr());
+            NativeMethods.git_status_list_free((git_status_list*)handle);
 
             return true;
         }
@@ -143,7 +143,7 @@ internal BlameHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_blame_free((git_blame*)AsIntPtr());
+            NativeMethods.git_blame_free((git_blame*)handle);
 
             return true;
         }
@@ -168,7 +168,7 @@ internal DiffHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_diff_free((git_diff*)AsIntPtr());
+            NativeMethods.git_diff_free((git_diff*)handle);
 
             return true;
         }
@@ -193,7 +193,7 @@ internal PatchHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_patch_free((git_patch*)AsIntPtr());
+            NativeMethods.git_patch_free((git_patch*)handle);
 
             return true;
         }
@@ -218,7 +218,7 @@ internal ConfigurationHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_config_free((git_config*)AsIntPtr());
+            NativeMethods.git_config_free((git_config*)handle);
 
             return true;
         }
@@ -243,7 +243,7 @@ internal ConflictIteratorHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_index_conflict_iterator_free((git_index_conflict_iterator*)AsIntPtr());
+            NativeMethods.git_index_conflict_iterator_free((git_index_conflict_iterator*)handle);
 
             return true;
         }
@@ -268,7 +268,7 @@ internal IndexHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_index_free((git_index*)AsIntPtr());
+            NativeMethods.git_index_free((git_index*)handle);
 
             return true;
         }
@@ -293,7 +293,7 @@ internal ReflogHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_reflog_free((git_reflog*)AsIntPtr());
+            NativeMethods.git_reflog_free((git_reflog*)handle);
 
             return true;
         }
@@ -318,7 +318,7 @@ internal TreeBuilderHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_treebuilder_free((git_treebuilder*)AsIntPtr());
+            NativeMethods.git_treebuilder_free((git_treebuilder*)handle);
 
             return true;
         }
@@ -343,7 +343,7 @@ internal PackBuilderHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_packbuilder_free((git_packbuilder*)AsIntPtr());
+            NativeMethods.git_packbuilder_free((git_packbuilder*)handle);
 
             return true;
         }
@@ -368,7 +368,7 @@ internal NoteHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_note_free((git_note*)AsIntPtr());
+            NativeMethods.git_note_free((git_note*)handle);
 
             return true;
         }
@@ -393,7 +393,7 @@ internal DescribeResultHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_describe_result_free((git_describe_result*)AsIntPtr());
+            NativeMethods.git_describe_result_free((git_describe_result*)handle);
 
             return true;
         }
@@ -418,7 +418,7 @@ internal SubmoduleHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_submodule_free((git_submodule*)AsIntPtr());
+            NativeMethods.git_submodule_free((git_submodule*)handle);
 
             return true;
         }
@@ -443,7 +443,7 @@ internal AnnotatedCommitHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_annotated_commit_free((git_annotated_commit*)AsIntPtr());
+            NativeMethods.git_annotated_commit_free((git_annotated_commit*)handle);
 
             return true;
         }
@@ -468,7 +468,7 @@ internal ObjectDatabaseHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_odb_free((git_odb*)AsIntPtr());
+            NativeMethods.git_odb_free((git_odb*)handle);
 
             return true;
         }
@@ -493,7 +493,7 @@ internal RevWalkerHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_revwalk_free((git_revwalk*)AsIntPtr());
+            NativeMethods.git_revwalk_free((git_revwalk*)handle);
 
             return true;
         }
@@ -518,7 +518,7 @@ internal RemoteHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_remote_free((git_remote*)AsIntPtr());
+            NativeMethods.git_remote_free((git_remote*)handle);
 
             return true;
         }
@@ -543,7 +543,7 @@ internal ObjectHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_object_free((git_object*)AsIntPtr());
+            NativeMethods.git_object_free((git_object*)handle);
 
             return true;
         }
@@ -568,7 +568,7 @@ internal RebaseHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_rebase_free((git_rebase*)AsIntPtr());
+            NativeMethods.git_rebase_free((git_rebase*)handle);
 
             return true;
         }
@@ -593,7 +593,7 @@ internal OdbStreamHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_odb_stream_free((git_odb_stream*)AsIntPtr());
+            NativeMethods.git_odb_stream_free((git_odb_stream*)handle);
 
             return true;
         }
@@ -618,7 +618,7 @@ internal WorktreeHandle(IntPtr ptr, bool owned)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.git_worktree_free((git_worktree*)AsIntPtr());
+            NativeMethods.git_worktree_free((git_worktree*)handle);
 
             return true;
         }
diff --git a/LibGit2Sharp/Core/Handles/Objects.tt b/LibGit2Sharp/Core/Handles/Objects.tt
@@ -84,7 +84,7 @@ for (var i = 0; i < cNames.Length; i++)
 
         protected override bool ReleaseHandle()
         {
-            NativeMethods.<#= cNames[i] #>_free((<#= cNames[i] #>*)AsIntPtr());
+            NativeMethods.<#= cNames[i] #>_free((<#= cNames[i] #>*)handle);
 
             return true;
         }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ internal TreeEntryHandle(IntPtr ptr, bool owned)`
`18`	`18`
`19`	`19`	`protected override bool ReleaseHandle()`
`20`	`20`	`{`
`21`		`- NativeMethods.git_tree_entry_free((git_tree_entry*)AsIntPtr());`
	`21`	`+ NativeMethods.git_tree_entry_free((git_tree_entry*)handle);`
`22`	`22`
`23`	`23`	`return true;`
`24`	`24`	`}`
`@@ -43,7 +43,7 @@ internal ReferenceHandle(IntPtr ptr, bool owned)`
`43`	`43`
`44`	`44`	`protected override bool ReleaseHandle()`
`45`	`45`	`{`
`46`		`- NativeMethods.git_reference_free((git_reference*)AsIntPtr());`
	`46`	`+ NativeMethods.git_reference_free((git_reference*)handle);`
`47`	`47`
`48`	`48`	`return true;`
`49`	`49`	`}`
`@@ -68,7 +68,7 @@ internal RepositoryHandle(IntPtr ptr, bool owned)`
`68`	`68`
`69`	`69`	`protected override bool ReleaseHandle()`
`70`	`70`	`{`
`71`		`- NativeMethods.git_repository_free((git_repository*)AsIntPtr());`
	`71`	`+ NativeMethods.git_repository_free((git_repository*)handle);`
`72`	`72`
`73`	`73`	`return true;`
`74`	`74`	`}`
`@@ -93,7 +93,7 @@ internal SignatureHandle(IntPtr ptr, bool owned)`
`93`	`93`
`94`	`94`	`protected override bool ReleaseHandle()`
`95`	`95`	`{`
`96`		`- NativeMethods.git_signature_free((git_signature*)AsIntPtr());`
	`96`	`+ NativeMethods.git_signature_free((git_signature*)handle);`
`97`	`97`
`98`	`98`	`return true;`
`99`	`99`	`}`
`@@ -118,7 +118,7 @@ internal StatusListHandle(IntPtr ptr, bool owned)`
`118`	`118`
`119`	`119`	`protected override bool ReleaseHandle()`
`120`	`120`	`{`
`121`		`- NativeMethods.git_status_list_free((git_status_list*)AsIntPtr());`
	`121`	`+ NativeMethods.git_status_list_free((git_status_list*)handle);`
`122`	`122`
`123`	`123`	`return true;`
`124`	`124`	`}`
`@@ -143,7 +143,7 @@ internal BlameHandle(IntPtr ptr, bool owned)`
`143`	`143`
`144`	`144`	`protected override bool ReleaseHandle()`
`145`	`145`	`{`
`146`		`- NativeMethods.git_blame_free((git_blame*)AsIntPtr());`
	`146`	`+ NativeMethods.git_blame_free((git_blame*)handle);`
`147`	`147`
`148`	`148`	`return true;`
`149`	`149`	`}`
`@@ -168,7 +168,7 @@ internal DiffHandle(IntPtr ptr, bool owned)`
`168`	`168`
`169`	`169`	`protected override bool ReleaseHandle()`
`170`	`170`	`{`
`171`		`- NativeMethods.git_diff_free((git_diff*)AsIntPtr());`
	`171`	`+ NativeMethods.git_diff_free((git_diff*)handle);`
`172`	`172`
`173`	`173`	`return true;`
`174`	`174`	`}`
`@@ -193,7 +193,7 @@ internal PatchHandle(IntPtr ptr, bool owned)`
`193`	`193`
`194`	`194`	`protected override bool ReleaseHandle()`
`195`	`195`	`{`
`196`		`- NativeMethods.git_patch_free((git_patch*)AsIntPtr());`
	`196`	`+ NativeMethods.git_patch_free((git_patch*)handle);`
`197`	`197`
`198`	`198`	`return true;`
`199`	`199`	`}`
`@@ -218,7 +218,7 @@ internal ConfigurationHandle(IntPtr ptr, bool owned)`
`218`	`218`
`219`	`219`	`protected override bool ReleaseHandle()`
`220`	`220`	`{`
`221`		`- NativeMethods.git_config_free((git_config*)AsIntPtr());`
	`221`	`+ NativeMethods.git_config_free((git_config*)handle);`
`222`	`222`
`223`	`223`	`return true;`
`224`	`224`	`}`
`@@ -243,7 +243,7 @@ internal ConflictIteratorHandle(IntPtr ptr, bool owned)`
`243`	`243`
`244`	`244`	`protected override bool ReleaseHandle()`
`245`	`245`	`{`
`246`		`- NativeMethods.git_index_conflict_iterator_free((git_index_conflict_iterator*)AsIntPtr());`
	`246`	`+ NativeMethods.git_index_conflict_iterator_free((git_index_conflict_iterator*)handle);`
`247`	`247`
`248`	`248`	`return true;`
`249`	`249`	`}`
`@@ -268,7 +268,7 @@ internal IndexHandle(IntPtr ptr, bool owned)`
`268`	`268`
`269`	`269`	`protected override bool ReleaseHandle()`
`270`	`270`	`{`
`271`		`- NativeMethods.git_index_free((git_index*)AsIntPtr());`
	`271`	`+ NativeMethods.git_index_free((git_index*)handle);`
`272`	`272`
`273`	`273`	`return true;`
`274`	`274`	`}`
`@@ -293,7 +293,7 @@ internal ReflogHandle(IntPtr ptr, bool owned)`
`293`	`293`
`294`	`294`	`protected override bool ReleaseHandle()`
`295`	`295`	`{`
`296`		`- NativeMethods.git_reflog_free((git_reflog*)AsIntPtr());`
	`296`	`+ NativeMethods.git_reflog_free((git_reflog*)handle);`
`297`	`297`
`298`	`298`	`return true;`
`299`	`299`	`}`
`@@ -318,7 +318,7 @@ internal TreeBuilderHandle(IntPtr ptr, bool owned)`
`318`	`318`
`319`	`319`	`protected override bool ReleaseHandle()`
`320`	`320`	`{`
`321`		`- NativeMethods.git_treebuilder_free((git_treebuilder*)AsIntPtr());`
	`321`	`+ NativeMethods.git_treebuilder_free((git_treebuilder*)handle);`
`322`	`322`
`323`	`323`	`return true;`
`324`	`324`	`}`
`@@ -343,7 +343,7 @@ internal PackBuilderHandle(IntPtr ptr, bool owned)`
`343`	`343`
`344`	`344`	`protected override bool ReleaseHandle()`
`345`	`345`	`{`
`346`		`- NativeMethods.git_packbuilder_free((git_packbuilder*)AsIntPtr());`
	`346`	`+ NativeMethods.git_packbuilder_free((git_packbuilder*)handle);`
`347`	`347`
`348`	`348`	`return true;`
`349`	`349`	`}`
`@@ -368,7 +368,7 @@ internal NoteHandle(IntPtr ptr, bool owned)`
`368`	`368`
`369`	`369`	`protected override bool ReleaseHandle()`
`370`	`370`	`{`
`371`		`- NativeMethods.git_note_free((git_note*)AsIntPtr());`
	`371`	`+ NativeMethods.git_note_free((git_note*)handle);`
`372`	`372`
`373`	`373`	`return true;`
`374`	`374`	`}`
`@@ -393,7 +393,7 @@ internal DescribeResultHandle(IntPtr ptr, bool owned)`
`393`	`393`
`394`	`394`	`protected override bool ReleaseHandle()`
`395`	`395`	`{`
`396`		`- NativeMethods.git_describe_result_free((git_describe_result*)AsIntPtr());`
	`396`	`+ NativeMethods.git_describe_result_free((git_describe_result*)handle);`
`397`	`397`
`398`	`398`	`return true;`
`399`	`399`	`}`
`@@ -418,7 +418,7 @@ internal SubmoduleHandle(IntPtr ptr, bool owned)`
`418`	`418`
`419`	`419`	`protected override bool ReleaseHandle()`
`420`	`420`	`{`
`421`		`- NativeMethods.git_submodule_free((git_submodule*)AsIntPtr());`
	`421`	`+ NativeMethods.git_submodule_free((git_submodule*)handle);`
`422`	`422`
`423`	`423`	`return true;`
`424`	`424`	`}`
`@@ -443,7 +443,7 @@ internal AnnotatedCommitHandle(IntPtr ptr, bool owned)`
`443`	`443`
`444`	`444`	`protected override bool ReleaseHandle()`
`445`	`445`	`{`
`446`		`- NativeMethods.git_annotated_commit_free((git_annotated_commit*)AsIntPtr());`
	`446`	`+ NativeMethods.git_annotated_commit_free((git_annotated_commit*)handle);`
`447`	`447`
`448`	`448`	`return true;`
`449`	`449`	`}`
`@@ -468,7 +468,7 @@ internal ObjectDatabaseHandle(IntPtr ptr, bool owned)`
`468`	`468`
`469`	`469`	`protected override bool ReleaseHandle()`
`470`	`470`	`{`
`471`		`- NativeMethods.git_odb_free((git_odb*)AsIntPtr());`
	`471`	`+ NativeMethods.git_odb_free((git_odb*)handle);`
`472`	`472`
`473`	`473`	`return true;`
`474`	`474`	`}`
`@@ -493,7 +493,7 @@ internal RevWalkerHandle(IntPtr ptr, bool owned)`
`493`	`493`
`494`	`494`	`protected override bool ReleaseHandle()`
`495`	`495`	`{`
`496`		`- NativeMethods.git_revwalk_free((git_revwalk*)AsIntPtr());`
	`496`	`+ NativeMethods.git_revwalk_free((git_revwalk*)handle);`
`497`	`497`
`498`	`498`	`return true;`
`499`	`499`	`}`
`@@ -518,7 +518,7 @@ internal RemoteHandle(IntPtr ptr, bool owned)`
`518`	`518`
`519`	`519`	`protected override bool ReleaseHandle()`
`520`	`520`	`{`
`521`		`- NativeMethods.git_remote_free((git_remote*)AsIntPtr());`
	`521`	`+ NativeMethods.git_remote_free((git_remote*)handle);`
`522`	`522`
`523`	`523`	`return true;`
`524`	`524`	`}`
`@@ -543,7 +543,7 @@ internal ObjectHandle(IntPtr ptr, bool owned)`
`543`	`543`
`544`	`544`	`protected override bool ReleaseHandle()`
`545`	`545`	`{`
`546`		`- NativeMethods.git_object_free((git_object*)AsIntPtr());`
	`546`	`+ NativeMethods.git_object_free((git_object*)handle);`
`547`	`547`
`548`	`548`	`return true;`
`549`	`549`	`}`
`@@ -568,7 +568,7 @@ internal RebaseHandle(IntPtr ptr, bool owned)`
`568`	`568`
`569`	`569`	`protected override bool ReleaseHandle()`
`570`	`570`	`{`
`571`		`- NativeMethods.git_rebase_free((git_rebase*)AsIntPtr());`
	`571`	`+ NativeMethods.git_rebase_free((git_rebase*)handle);`
`572`	`572`
`573`	`573`	`return true;`
`574`	`574`	`}`
`@@ -593,7 +593,7 @@ internal OdbStreamHandle(IntPtr ptr, bool owned)`
`593`	`593`
`594`	`594`	`protected override bool ReleaseHandle()`
`595`	`595`	`{`
`596`		`- NativeMethods.git_odb_stream_free((git_odb_stream*)AsIntPtr());`
	`596`	`+ NativeMethods.git_odb_stream_free((git_odb_stream*)handle);`
`597`	`597`
`598`	`598`	`return true;`
`599`	`599`	`}`
`@@ -618,7 +618,7 @@ internal WorktreeHandle(IntPtr ptr, bool owned)`
`618`	`618`
`619`	`619`	`protected override bool ReleaseHandle()`
`620`	`620`	`{`
`621`		`- NativeMethods.git_worktree_free((git_worktree*)AsIntPtr());`
	`621`	`+ NativeMethods.git_worktree_free((git_worktree*)handle);`
`622`	`622`
`623`	`623`	`return true;`
`624`	`624`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ for (var i = 0; i < cNames.Length; i++)`
`84`	`84`
`85`	`85`	`protected override bool ReleaseHandle()`
`86`	`86`	`{`
`87`		`- NativeMethods.<#= cNames[i] #>_free((<#= cNames[i] #>*)AsIntPtr());`
	`87`	`+ NativeMethods.<#= cNames[i] #>_free((<#= cNames[i] #>*)handle);`
`88`	`88`
`89`	`89`	`return true;`
`90`	`90`	`}`