New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hiredis.c should return git_error_code, not git_error_t? #8

Open

sgundry opened this issue Mar 1, 2015 · 1 comment

sgundry commented Mar 1, 2015

Should hiredis.c return a git_error_code type and not git_error_t? Libgit2 checks for if (error < 0) which does not catch git_error_t types.

This manifested in a nullptr instead of an error when trying git_blob_lookup_prefix against hiredis backend.

See https://github.com/libgit2/libgit2-backends/blob/master/redis/hiredis.c#L158 and https://github.com/libgit2/libgit2/blob/master/src/object.c#L190.

ideal commented Oct 27, 2015

You are right.

return code for error should be below than 0. git_error_t is for giterr_set().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment