Skip to content

Commit e4b02ff

Browse files
d-e-s-odanielocfb
authored andcommitted
Improve documentation surrounding code_info & inlined_fns flags
The documentation surrounding the code_info and inlined_fns flags is somewhat lacking and partly incorrect. Both flags require debug_syms of the particular source to be enabled in order to have an effect. State that explicitly. Signed-off-by: Daniel Müller <[email protected]>
1 parent 8b84402 commit e4b02ff

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

capi/include/blazesym.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,11 +575,14 @@ typedef struct blaze_symbolizer_opts {
575575
/**
576576
* Whether to attempt to gather source code location information.
577577
*
578-
* This setting implies `debug_syms` (and forces it to `true`).
578+
* This option only has an effect if `debug_syms` of the particular
579+
* symbol source is set to `true`.
579580
*/
580581
bool code_info;
581582
/**
582583
* Whether to report inlined functions as part of symbolization.
584+
*
585+
* This option only has an effect if `code_info` is `true`.
583586
*/
584587
bool inlined_fns;
585588
/**

capi/src/symbolize.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,9 +672,12 @@ pub struct blaze_symbolizer_opts {
672672
pub auto_reload: bool,
673673
/// Whether to attempt to gather source code location information.
674674
///
675-
/// This setting implies `debug_syms` (and forces it to `true`).
675+
/// This option only has an effect if `debug_syms` of the particular
676+
/// symbol source is set to `true`.
676677
pub code_info: bool,
677678
/// Whether to report inlined functions as part of symbolization.
679+
///
680+
/// This option only has an effect if `code_info` is `true`.
678681
pub inlined_fns: bool,
679682
/// Whether or not to transparently demangle symbols.
680683
///

src/symbolize/symbolizer.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,9 @@ impl Builder {
279279

280280
/// Enable/disable source code location information (line numbers,
281281
/// file names etc.).
282+
///
283+
/// This option only has an effect if `debug_syms` of the particular
284+
/// symbol source is set to `true`.
282285
pub fn enable_code_info(mut self, enable: bool) -> Self {
283286
self.code_info = enable;
284287
self

0 commit comments

Comments
 (0)