Overhaul and reuse workspace-wide Rust lints

Overhaul the set of Rust lints in use and make them apply in a
workspace-wide manner. Fix everything new that is being flagged.

Signed-off-by: Daniel Müller <[email protected]>

Author: d-e-s-o

Cargo.toml

@@ -18,6 +18,37 @@ license = "BSD-3-Clause"
 repository = "https://github.com/libbpf/blazesym"
 homepage = "https://github.com/libbpf/blazesym"
 
+[workspace.lints.rust]
+deprecated-safe = "warn"
+future-incompatible = "warn"
+keyword-idents = "warn"
+let-underscore = "warn"
+missing-debug-implementations = "warn"
+missing-docs = "warn"
+trivial-numeric-casts = "warn"
+unexpected_cfgs = {level = "warn", check-cfg = ['cfg(has_procmap_query_ioctl)', 'cfg(has_large_test_files)']}
+unsafe-op-in-unsafe-fn = "warn"
+unused = "warn"
+
+[workspace.lints.clippy]
+collapsible-else-if = "allow"
+collapsible-if = "allow"
+fn-to-numeric-cast = "allow"
+let-and-return = "allow"
+let-unit-value = "allow"
+module-inception = "allow"
+type-complexity = "allow"
+absolute-paths = "warn"
+allow-attributes = "warn"
+clone-on-ref-ptr = "warn"
+dbg-macro = "warn"
+doc-markdown = "warn"
+join-absolute-paths = "warn"
+large-enum-variant = "warn"
+redundant-closure-for-method-calls = "warn"
+unchecked-duration-subtraction = "warn"
+uninlined-format-args = "warn"
+
 [package]
 name = "blazesym"
 description = "blazesym is a library for address symbolization and related tasks."
@@ -171,5 +202,5 @@ features = ["apk", "backtrace", "breakpad", "demangle", "dwarf", "gsym"]
 # defines the configuration attribute `docsrs`
 rustdoc-args = ["--cfg", "docsrs"]
 
-[lints.rust]
-unexpected_cfgs = {level = "warn", check-cfg = ['cfg(has_procmap_query_ioctl)', 'cfg(has_large_test_files)']}
+[lints]
+workspace = true

benches/main.rs

@@ -1,8 +1,6 @@
-#![allow(
-    clippy::incompatible_msrv,
-    clippy::let_and_return,
-    clippy::let_unit_value
-)]
+//! Benchmarks for `blazesym`.
+
+#![allow(missing_docs)]
 
 macro_rules! bench_fn {
     ($group:expr, $bench_fn:ident) => {

benches/normalize.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::fn_to_numeric_cast)]
-
 use std::hint::black_box;
 
 use blazesym::normalize::NormalizeOpts;

benches/symbolize.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::fn_to_numeric_cast)]
-
 use std::hint::black_box;
 use std::path::Path;
 

build.rs

@@ -1,3 +1,5 @@
+//! Build script for `blazesym`.
+
 use std::env;
 
 

capi/Cargo.toml

@@ -89,3 +89,6 @@ criterion = {git = "https://github.com/bheisler/criterion.rs.git", rev = "b913e2
 tempfile = "3.19"
 test-log = {version = "0.2.14", default-features = false, features = ["trace"]}
 test-tag = "0.1"
+
+[lints]
+workspace = true

capi/benches/capi.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::let_and_return, clippy::let_unit_value)]
+#![allow(missing_docs)]
 
 macro_rules! bench_fn {
     ($group:expr, $bench_fn:ident) => {

capi/benches/normalize.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::fn_to_numeric_cast, clippy::incompatible_msrv)]
-
 use std::hint::black_box;
 use std::ptr;
 

capi/build.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::let_unit_value)]
+//! Build script for `blazesym-c`.
 
 use std::env;
 use std::ffi::OsStr;

capi/src/error.rs

@@ -77,7 +77,7 @@ thread_local! {
 /// Retrieve the error reported by the last fallible API function invoked.
 #[no_mangle]
 pub extern "C" fn blaze_err_last() -> blaze_err {
-    LAST_ERR.with(|cell| cell.get())
+    LAST_ERR.with(Cell::get)
 }
 
 /// Retrieve the error reported by the last fallible API function invoked.