Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN translation #50

Open
strawhat-dev opened this issue Jul 31, 2024 · 9 comments · May be fixed by #47
Open

EN translation #50

strawhat-dev opened this issue Jul 31, 2024 · 9 comments · May be fixed by #47
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@strawhat-dev
Copy link

Has an EN translation ever been planned for this app any time in the future? If not, I have quickly setup a rudimentary version, which does some static translations and auto translates everything else, which should get the job done. You could possibly link users looking for an "English version" in your README to here - https://github.com/strawhat-dev/HoYo.Gacha.DarkEN

Any future updates shouldn't require me to manually add any new translations, with the only downside being translate-shell as an extra dependency. Thanks for the useful app!

------------------------------------- AI 翻译 -------------------------------------

这个应用未来有计划推出英文翻译版吗?如果没有,我已经快速搭建了一个基础版本,它可以进行一些静态翻译,并自动翻译其他所有内容,应该能够完成任务。你可能会想在你的README中为寻找“英文版本”的用户提供一个链接到这里 - https://github.com/strawhat-dev/HoYo.Gacha.DarkEN

任何将来的更新都不应该要求我手动添加新的翻译,唯一的缺点是需要translate-shell作为额外依赖。感谢这款实用的应用!

@lgou2w
Copy link
Owner

lgou2w commented Jul 31, 2024

👍 Thanks for your work.
The new version is being refactored. Multiple languages will be supported.
You can track these issues: #28, #47

@lgou2w lgou2w added enhancement New feature or request question Further information is requested labels Jul 31, 2024
@da3dsoul1
Copy link

Please add English language 🙏
This program is so good, but I can't read Chinese, and I have to image translate all the time :C

@lgou2w
Copy link
Owner

lgou2w commented Aug 6, 2024

Please add English language 🙏 This program is so good, but I can't read Chinese, and I have to image translate all the time :C

New v1 version is under development. Multiple languages will be supported.

Settings (Preview):
HoYo Gacha v1 Preview Settings

@lgou2w lgou2w added this to the v1.0.0 milestone Aug 6, 2024
@strawhat-dev
Copy link
Author

Please add English language 🙏 This program is so good, but I can't read Chinese, and I have to image translate all the time :C

@da3dsoul1 Did you try out my temporary patched version, which I mentioned above yet?

@da3dsoul1
Copy link

da3dsoul1 commented Aug 7, 2024

@lgou2w thank you for your work!

@strawhat-dev yep, right now using it, ty!

Also is this possible to run the program portable? So it stores all it's data in a folder and I can transfer it from one pc to the other without losing any progress?

@strawhat-dev
Copy link
Author

Also is this possible to run the program portable?

@da3dsoul1 After building, you should be able to just move the built app directory which should be ./HoYo.Gacha/target/release, which contains HoYo_Gacha.exe, anywhere.

@da3dsoul1
Copy link

Also is this possible to run the program portable?

@da3dsoul1 After building, you should be able to just move the built app directory which should be ./HoYo.Gacha/target/release, which contains HoYo_Gacha.exe, anywhere.

It stores data in %appdata$/local, it's not 100% portable

@lgou2w
Copy link
Owner

lgou2w commented Aug 7, 2024

Also is this possible to run the program portable?

@da3dsoul1 After building, you should be able to just move the built app directory which should be ./HoYo.Gacha/target/release, which contains HoYo_Gacha.exe, anywhere.

It stores data in %appdata$/local, it's not 100% portable

%appdata%/local is the user profile data of Microsoft Webview2.
All account and gacha records data is in the HoYo.Gacha.db database file in the same directory as exe.

@da3dsoul1
Copy link

Also is this possible to run the program portable?

@da3dsoul1 After building, you should be able to just move the built app directory which should be ./HoYo.Gacha/target/release, which contains HoYo_Gacha.exe, anywhere.

It stores data in %appdata$/local, it's not 100% portable

%appdata%/local is the user profile data of Microsoft Webview2. All account and gacha records data is in the HoYo.Gacha.db database file in the same directory as exe.

Oh okay, thanks for the clarification!

@lgou2w lgou2w linked a pull request Sep 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants