Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes detection only based on commits (like standard-version) #958

Open
3 tasks done
farfromrefug opened this issue Nov 7, 2024 · 2 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@farfromrefug
Copy link
Contributor

Clear and concise description of the problem

Right now changes are based on files.
This actually create some issues of changes not detected in all my lerna projects. And i now know why. my packages are built into output dirs which are not committed. It is then those output folders that i use as lerna "packages". Thus it cant see changes.
It finally makes sense.

Suggested solution

Another way of detecting changes is simply to look at conventional commits and see if you find some which are not ignored (scope).
This is what standard-version does.
i think it is a better way because it does not rely on files/folders.
Then remains the detection of which packages have changed. It could also be done by looking at the location of the files modified in the found commits (i think it is also what standard-version does)

Alternative

No response

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@ghiscoding
Copy link
Member

if you want to work on this then fine but otherwise I personally will not work on this since it's outside the goal of this project (maintenance is the main goal). I did implement new features, but this one is way out of my comfort zone and I'm not planning on working on this. So unless you want to work on this yourself great, if not I'll close this request (sorry).

@farfromrefug
Copy link
Contributor Author

@ghiscoding I might work on this yes. Just not sure when. So would be nice to leave this open.

@ghiscoding ghiscoding added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants