-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hot reload] Hot reload broken for children after components #3191
Comments
Thanks. This is much better than the version in the discussion, because 1) it includes the app you're using and 2) it has a specific "do this and this breaks." Specifically, the issue here seems to be "Hot reloading doesn't work after components that return Playing around with your example I notice also that it doesn't work with raw text nodes (as opposed to quoted string nodes). Like I said I haven't really touched any of the hot reloading code in about a year and a half... it's possible we didn't even support unquoted text nodes when I wrote it. Thanks for the example, will list this as a nice-to-have thing to fix in 0.7 but not a blocker for releasing that. |
so is there something I can do until this is fixed? Im asking because it is a huge disadvantage not having this hot-readling feature since it is a nice DX. especially when you are on a slow machine and compiling the WASM is very slow (like in my case). |
Here are some options:
For example, to test out this hypothesis I opened up your app, and started editing a separate example.mov |
Describe the bug
To reproduce clone this repo, which is a fresh starter axum-0.7 template with additionally tailwind included.
https://github.com/omani/lep7
as mentioned in discussion #2919:
hey @gbj. has something changed recently? I again started with the axum-0.7 template and hot-reloading works, but totally wrong children are being replaced in my browser. Im adding a
<p>
for example, and a weird button is added to the DOM. also removing children does not work properly. this is a very weird behavour I hadnt seen 2 months ago (back then when I had set up the axum template with tailwind, etc.).there is a button below the
<p>
. I remove the<p>
and the button is removed in the DOM (all of this while using --hot-reload ofc). very strange.tested with firefox and chromium.
this video shows the weird behavour: https://github.com/user-attachments/assets/cb71fe4c-bba6-478e-816a-9f25cf58d851
out_1.mp4
Leptos Dependencies
Please copy and paste the Leptos dependencies and features from your
Cargo.toml
.For example:
To Reproduce
Steps to reproduce the behavior:
cargo leptos watch --hot-reload
App
component's view (add a `' or something else)
Expected behavior
I expect it to insert/update the correct child/children when changing something in the HTML view
Screenshots
see link to discussion video above
Additional context
this wasn't the case 3 months ago. this is new to me.
The text was updated successfully, but these errors were encountered: