Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove soon to be defunct macos-12 builds #222

Open
raphaelshirley opened this issue Oct 17, 2024 · 4 comments
Open

Remove soon to be defunct macos-12 builds #222

raphaelshirley opened this issue Oct 17, 2024 · 4 comments
Assignees

Comments

@raphaelshirley
Copy link
Member

Apparently the macos-12 runner will be removed

s3fs-fuse/s3fs-fuse#2552

I can see macos-12 in

https://github.com/lephare-photoz/lephare/blob/main/.github/workflows/publish-to-pypi.yml
https://github.com/lephare-photoz/lephare/blob/main/.github/workflows/testing-mac-only.yml
https://github.com/lephare-photoz/lephare/blob/main/.github/workflows/compile-cpp.yml

Shall we delete?, replace with macos-13 or macos-latest?

I think we may have prevously had issues with latest.

@raphaelshirley raphaelshirley self-assigned this Oct 17, 2024
@johannct
Copy link
Member

Go for macos-13 then. ubuntu on the other hand could be latest everywhere, I believe, but let's leave that aside for now

@raphaelshirley
Copy link
Member Author

I seem to remember a discussion with @drewoldag about not using 'latest' on perhaps ubuntu or mac but I can't remember why we rejected it. I think it kept introducing breaking changes?

@drewoldag
Copy link
Collaborator

My memory is that using latest will just mean that things might change without you being aware of it. So under the hood latest may change (e.g. from 13 to 14) and break. If that happens and it breaks something it is very challenging to determine why. From your perspective nothing changed, and github isn't great about advertising those kinds of changes.

So macos-13 should be fine.

Here's the current list of hosted runners available: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@johannct
Copy link
Member

yes agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants