Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF::int_parab should provide the y value of the chimin #199

Open
johannct opened this issue Sep 5, 2024 · 0 comments
Open

PDF::int_parab should provide the y value of the chimin #199

johannct opened this issue Sep 5, 2024 · 0 comments
Assignees

Comments

@johannct
Copy link
Member

johannct commented Sep 5, 2024

I see a couple of issues with this method :

  • I did not see that there is a check that the three points are not aligned
  • the naming is not great : it is not an interpolation but a search for a local extremum; as a matter of fact I am not even sure that this extremum is constrained to lie inside the range defined by the 3 points
  • The confidence interval code relies on the determination of the zmin from this function, but uses chimin[ib] as the minimal value of the chi2 to compute the confidence interval. This seems inconsistent : the value of the chi2 curve at the zmin obtained by int_parab should be used instead. Thus int_parab should return the y value as well : chi2 at zmin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants