Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codacy changes #16

Open
rajikaimal opened this issue Mar 19, 2019 · 1 comment
Open

Codacy changes #16

rajikaimal opened this issue Mar 19, 2019 · 1 comment

Comments

@rajikaimal
Copy link
Member

Take Codacy suggestions into account and make necessary changes to improve the code quality.

@rajitha1998
Copy link
Member

I am currently working on adding Codacy suggestions. I would like to know some details regarding this @rajikaimal .

  • Codacy was showing some suggestions under the category of Error Prone which I assume that the console logs were added to display the output of this example or to display an error message.
    E.g. -
    Capture
    Do we need to remove these console logs?

  • I have corrected all code style suggestions on JavaScript.

  • I have formatted the readme file using a markdown plugin since codacy was showing some formatting issues with readme file.

  • I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored const ncConfig = require(path.join(process.cwd(), ".nc.config"));
    Capture

I would like to make any changes according to your suggestions regarding this PR @rajikaimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants