Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export internal type definitions #1143

Open
RikuVan opened this issue Jun 5, 2021 · 1 comment
Open

export internal type definitions #1143

RikuVan opened this issue Jun 5, 2021 · 1 comment
Labels
Feature Feature requests/suggestions

Comments

@RikuVan
Copy link

RikuVan commented Jun 5, 2021

This is a super library (thanks!) and, therefore, I am lightly wrapping it in a more idiomatic way for React (in a hook) and Svelte (using a store). The wrapper requires the same options as noUISlider so I have found myself reproducing the internal types where there are some small api tweaks It would be nicer to consume them all directly from noUISlider. I would be willing to make the PR if this seems reasonable to you. Alternatively, it is not a big deal to just pick them off the exported Options interface. So this not at all a blocking issue. But I think it would make it a little easier to extend some particular types.

@leongersen
Copy link
Owner

I'm very open to your suggestions on this. I've initially only exported the types I needed for the current set of examples and documentation, but I figure some other ones are externally useful. I'd welcome a PR!

@leongersen leongersen added this to the 15.2.0 milestone Jun 6, 2021
@leongersen leongersen added the Feature Feature requests/suggestions label Jun 15, 2021
@leongersen leongersen modified the milestones: 15.2.0, 15.3.0 Jun 15, 2021
@leongersen leongersen removed this from the 15.3.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requests/suggestions
Projects
None yet
Development

No branches or pull requests

2 participants