Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no ability to use MachineOptions (WithYear) with nontransparent/octetcounting parsers #21

Open
dehaansa opened this issue Dec 31, 2024 · 0 comments
Open

There is no ability to use MachineOptions (WithYear) with nontransparent/octetcounting parsers #21

dehaansa opened this issue Dec 31, 2024 · 0 comments

Comments

@dehaansa
Copy link

dehaansa commented Dec 31, 2024 •
edited
Loading

This library is used in grafana/loki and then that code is used within grafana/alloy as well, and a user encountered an issue with the default 0'd out year with a RFC3164 message grafana/alloy#2287 . I went to go update the loki code to use the WithYear/CurrentYear option but that code uses the nontransparent & octetcounting parsers, rather than the rfc3164 & rfc5424 parsers.

I would propose updating the parsers to support these options. I think an ideal world would unify the With to no longer have separate ParserOption & MachineOption function types, but at least support for WithYear in the other parsers would unblock these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dehaansa