Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No error when accessing a private app I don't have access to #579

Open
shiipou opened this issue Sep 30, 2023 · 0 comments
Open

[Bug]: No error when accessing a private app I don't have access to #579

shiipou opened this issue Sep 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@shiipou
Copy link
Contributor

shiipou commented Sep 30, 2023

What happened?

There is no client-side error when trying to access a private app I don't have access.
But there is one in the server logs.

Note that the error is sent to the client via the websocket so we need to find a way to catch the error and properly show the UI. We also might want to change the returned error to be a 404 instead ?

What browsers are you seeing the problem on?

Firefox

Version

v1.0.0-beta.174

Relevant log output

09:00:11.615 [error] forbidden
lib/lenra_web/channels/app_socket.ex:2 Elixir.LenraWeb.AppSocket.connect/3
lib/phoenix/socket.ex:550 Elixir.Phoenix.Socket.user_connect/6
lib/phoenix/socket.ex:438 Elixir.Phoenix.Socket.__connect__/3
lib/phoenix/transports/websocket.ex:33 Elixir.Phoenix.Transports.WebSocket.connect/4
lib/phoenix/endpoint/cowboy2_handler.ex:22 Elixir.Phoenix.Endpoint.Cowboy2Handler.init/4
/app/deps/cowboy/src/cowboy_handler.erl:37 cowboy_handler.execute/2
@shiipou shiipou added the bug Something isn't working label Sep 30, 2023
@jonas-martinez jonas-martinez changed the title [Bug]: No error when trying accessing to a private app I don't have access [Bug]: No error when accessing a private app I don't have access to Dec 13, 2023
@taorepoara taorepoara transferred this issue from lenra-io/lenra_cli May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants